Looks like tests will need fixing. And for SA issues you can suppress them.

Hm should I split tests into AnnotationDriver-exists-or-not? Or sprinkle them with class_exists? 🤔

My preference would be to upgrade current tests to use attribute instead of annotation and skip them for orm < 3.x

We don't need to skip them for ORM 2.x AFAIK. Attributes are supported there as well (on PHP 8+)

Do I keep the DoctrineExtensionTest::testAnnotationsBundleMappingDetection?

you can remove it

Okay, done. Not sure why some tests are still failing though 🤔

I think those test failures are a symptom of this branch not being triggered now :( https://github.com/symfony/symfony/blob/c905bb4db3eec98e156199341891f62247f83fb6/src/Symfony/Bridge/Doctrine/DependencyInjection/AbstractDoctrineExtension.php#L224

Waat so the Doctrine Bridge does need to be updated 😅

I don't know, just saying that's the cause why tests fail. Proper course of action would be to find out why was that code branch added and find if same reasoning still applies nowadays. Then we know if we need to preserve the behavior somehow, or adjust tests

See symfony/symfony#53681; seems that we cannot be compatible with Symfony < 6.4 by returning XML and YAML drivers’ class name instead of the parameter.

Maybe this PR should focus to simply returning the correct PHP driver’s class name? That would fix symfony/symfony#58738, hopefully without any side effect.

I believe we just need to backport symfony/symfony#53681 to 5.4 branch. It's either that, or we cut off symfony/doctrine-bridge 5.4.x support here

Okay opened symfony/symfony#58772

Woops this got closed with symfony/symfony#58772 and I cannot reopen it 😓

Can someone do it for me or should I open another PR?

EDIT: thanks @nicolas-grekas 🙏

Last thing needed here I think is to adjust symfony/doctrine-bridge requirement to ensure we don't install < 5.4.46 version

Shouldn’t the ^6.0.7 constraint be bumped to ^6.4.3 and ^7.0 to ^7.0.3 so that we’re sure we got the fix?

indeed

CI is green 🎉

I know a bundle wiring is not under BC guarantee but is it really desirable to introduce such BC breaks in a patch version?

If you had a custom XML driver registered for instance, this entirely breaks the app and not necessarily in an obvious way (as commonly found with wiring issues).

It's also not really clear what is the upgrade path in this case.