-
Notifications
You must be signed in to change notification settings - Fork 3
Bump org.apache.httpcomponents.client5:httpclient5 from 5.4.1 to 5.4.3 in /dockstore-client/generated/src/main/resources #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dependabot rebase |
Bumps [org.apache.httpcomponents.client5:httpclient5](https://github.com/apache/httpcomponents-client) from 5.4.1 to 5.4.3. - [Changelog](https://github.com/apache/httpcomponents-client/blob/rel/v5.4.3/RELEASE_NOTES.txt) - [Commits](apache/httpcomponents-client@rel/v5.4.1...rel/v5.4.3) --- updated-dependencies: - dependency-name: org.apache.httpcomponents.client5:httpclient5 dependency-version: 5.4.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
1924653 to
d5a2a3a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #307 +/- ##
==============================================
- Coverage 70.22% 23.80% -46.43%
+ Complexity 1068 398 -670
==============================================
Files 47 48 +1
Lines 6069 6041 -28
Branches 801 798 -3
==============================================
- Hits 4262 1438 -2824
- Misses 1466 4416 +2950
+ Partials 341 187 -154
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dockstore-cli-integration-testing/generated/src/main/resources/pom.xml
Outdated
Show resolved
Hide resolved
|
(note to self, do a rebase rather than squash and merge since the version change is kinda unrelated but worth doing, maybe we should add it to the release process) |
kathy-t
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the httpclient5 version update in any of the pom files, is that expected?
Good catch, I had a brain fart since I did dockstore/dockstore#6101 at the same time. I actually need to do a 1.18 alpha and rely on that here |
| <dependency> | ||
| <groupId>org.apache.httpcomponents.client5</groupId> | ||
| <artifactId>httpclient5</artifactId> | ||
| <version>5.4.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
httpclient change is back in
|
Bumps org.apache.httpcomponents.client5:httpclient5 from 5.4.1 to 5.4.3.
Changelog
Sourced from org.apache.httpcomponents.client5:httpclient5's changelog.
... (truncated)
Commits
48236f5HttpClient 5.4.3 release36e40cdUpdated release notes for HttpClient 5.4.3 released5622dcMultipartEntityBuilder to include a random UUID in the boundary value by default8d0f3b1HTTPCLIENT-2363: ensure requests have a scheme and an authority populated bef...783502eUpgraded HttpCore to version 5.3.498e8e9dUpdated MultipartEntityBuilder javadocs clarifying content validation and san...bff9c47Fix PublicSuffixMatcherLoader#getDefault (#621)b7ece75HTTPCLIENT-2361: Tolerate multipleCookieheaders added by the callerad82f0dUpgraded HttpClient version to 5.4.3-SNAPSHOT2145d2cUpdated release notes for HttpClient 5.4.2 releaseDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.