Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 24, 2025

Bumps org.apache.httpcomponents.client5:httpclient5 from 5.4.1 to 5.4.3.

Changelog

Sourced from org.apache.httpcomponents.client5:httpclient5's changelog.

Release 5.4.3

This maintenance release upgrades HttpCore to version 5.3.4 and fixes a regression preventing the PublicSuffixMatcherLoader from finding the resource containing the Public Suffix List and causing the Public Suffix List to be empty by default.

Change Log

  • MultipartEntityBuilder to include a random UUID in the boundary value by default. Contributed by Oleg Kalnichevski

  • HTTPCLIENT-2363: Ensure requests have a scheme and an authority populated before they get committed to the execution pipeline. Contributed by Oleg Kalnichevski

  • Upgraded HttpCore to version 5.3.4. Contributed by Oleg Kalnichevski

  • Fix PublicSuffixMatcherLoader#getDefault (#621). Contributed by Joe Gallo joegallo@gmail.com

  • HTTPCLIENT-2361: HTTP protocol handler to tolerate multiple Cookie headers added manually by the caller. Contributed by Oleg Kalnichevski

Release 5.4.2

This maintenance release upgrades HttpCore to version 5.3.3 and fixes several regressions reported since the last release. One of the regressions could cause connection leaks and eventual connection pool exhaustion in case of proxy authentication failure when establishing a tunnel via the proxy.

Change Log

  • Upgraded HttpCore to version 5.3.3 Contributed by Oleg Kalnichevski

  • Improved internal state representation of the internal async execution runtime in order to prevent potential race conditions. Contributed by Oleg Kalnichevski

  • HTTPCLIENT-2357, regression: Classic HttpClient fails to release connection in case of a proxy authentication failure.

... (truncated)

Commits
  • 48236f5 HttpClient 5.4.3 release
  • 36e40cd Updated release notes for HttpClient 5.4.3 release
  • d5622dc MultipartEntityBuilder to include a random UUID in the boundary value by default
  • 8d0f3b1 HTTPCLIENT-2363: ensure requests have a scheme and an authority populated bef...
  • 783502e Upgraded HttpCore to version 5.3.4
  • 98e8e9d Updated MultipartEntityBuilder javadocs clarifying content validation and san...
  • bff9c47 Fix PublicSuffixMatcherLoader#getDefault (#621)
  • b7ece75 HTTPCLIENT-2361: Tolerate multiple Cookie headers added by the caller
  • ad82f0d Upgraded HttpClient version to 5.4.3-SNAPSHOT
  • 2145d2c Updated release notes for HttpClient 5.4.2 release
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Apr 24, 2025
@denis-yuen denis-yuen self-assigned this May 13, 2025
@denis-yuen
Copy link
Member

@dependabot rebase

Bumps [org.apache.httpcomponents.client5:httpclient5](https://github.com/apache/httpcomponents-client) from 5.4.1 to 5.4.3.
- [Changelog](https://github.com/apache/httpcomponents-client/blob/rel/v5.4.3/RELEASE_NOTES.txt)
- [Commits](apache/httpcomponents-client@rel/v5.4.1...rel/v5.4.3)

---
updated-dependencies:
- dependency-name: org.apache.httpcomponents.client5:httpclient5
  dependency-version: 5.4.3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/dockstore-client/generated/src/main/resources/org.apache.httpcomponents.client5-httpclient5-5.4.3 branch from 1924653 to d5a2a3a Compare May 13, 2025 18:23
@denis-yuen denis-yuen requested review from a team, denis-yuen, kathy-t and svonworl and removed request for a team May 13, 2025 19:27
@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.80%. Comparing base (d290680) to head (df63945).
Report is 64 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (d290680) and HEAD (df63945). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d290680) HEAD (df63945)
1 0
Additional details and impacted files
@@              Coverage Diff               @@
##             develop     #307       +/-   ##
==============================================
- Coverage      70.22%   23.80%   -46.43%     
+ Complexity      1068      398      -670     
==============================================
  Files             47       48        +1     
  Lines           6069     6041       -28     
  Branches         801      798        -3     
==============================================
- Hits            4262     1438     -2824     
- Misses          1466     4416     +2950     
+ Partials         341      187      -154     
Flag Coverage Δ
bitbuckettests 0.00% <ø> (-9.84%) ⬇️
confidentialtooltests 0.00% <ø> (-55.85%) ⬇️
confidentialworkflowtests 0.00% <ø> (-30.21%) ⬇️
nonconfidentialtests 23.12% <ø> (-9.27%) ⬇️
singularitytests 0.00% <ø> (-16.60%) ⬇️
toilintegrationtests 15.32% <ø> (?)
unittests 0.48% <ø> (-7.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@denis-yuen
Copy link
Member

(note to self, do a rebase rather than squash and merge since the version change is kinda unrelated but worth doing, maybe we should add it to the release process)

@denis-yuen denis-yuen requested a review from svonworl May 20, 2025 18:36
@denis-yuen denis-yuen mentioned this pull request May 20, 2025
9 tasks
Copy link
Contributor

@kathy-t kathy-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the httpclient5 version update in any of the pom files, is that expected?

@denis-yuen
Copy link
Member

I don't see the httpclient5 version update in any of the pom files, is that expected?

Good catch, I had a brain fart since I did dockstore/dockstore#6101 at the same time. I actually need to do a 1.18 alpha and rely on that here

README.md Outdated Show resolved Hide resolved
<dependency>
<groupId>org.apache.httpcomponents.client5</groupId>
<artifactId>httpclient5</artifactId>
<version>5.4.1</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

httpclient change is back in

@denis-yuen denis-yuen requested a review from kathy-t May 21, 2025 18:22
@sonarqubecloud
Copy link

@denis-yuen denis-yuen merged commit c5470e7 into develop May 22, 2025
17 of 18 checks passed
@denis-yuen denis-yuen deleted the dependabot/maven/dockstore-client/generated/src/main/resources/org.apache.httpcomponents.client5-httpclient5-5.4.3 branch May 22, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.