Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@hyunnaye
Copy link
Contributor

@hyunnaye hyunnaye commented Aug 4, 2023

Description
This PR allows file provisioning to display source and destination paths.

Review Instructions

  1. Remove ~/.dockstore/libraries/
  2. Run dockstore workflow launch --entry github.com/dockstore-testing/Metaphlan-WDL:master and see cromwell download with the source and destination path logged like below.
> dockstore workflow launch --entry github.com/dockstore-testing/Metaphlan-WDL:master 
WARNING: Docker is not running. If this workflow uses Docker, it will fail.
Saving https://github.com/broadinstitute/cromwell/releases/download/84/cromwell-84.jar to /home/nhyun/.dockstore/libraries/cromwell-84.jar
[##########################                        ] 53%

Issue
https://ucsc-cgl.atlassian.net/browse/DOCK-2323

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +1.66% 🎉

Comparison is base (ad4a2ea) 68.71% compared to head (7184278) 70.37%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #252      +/-   ##
=============================================
+ Coverage      68.71%   70.37%   +1.66%     
- Complexity      1010     1048      +38     
=============================================
  Files             47       47              
  Lines           6067     6070       +3     
  Branches         799      799              
=============================================
+ Hits            4169     4272     +103     
+ Misses          1556     1455     -101     
- Partials         342      343       +1     
Flag Coverage Δ
bitbuckettests 9.83% <0.00%> (-0.01%) ⬇️
confidentialtooltests 55.66% <66.66%> (+3.99%) ⬆️
confidentialworkflowtests 30.52% <66.66%> (+0.01%) ⬆️
nonconfidentialtests 32.28% <66.66%> (+0.01%) ⬆️
singularitytests 16.58% <66.66%> (+0.02%) ⬆️
unittests 8.35% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ain/java/io/dockstore/common/FileProvisioning.java 70.51% <66.66%> (-0.04%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 2 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@hyunnaye hyunnaye merged commit 7539c18 into develop Aug 8, 2023
@hyunnaye hyunnaye deleted the DOCK-2323 branch August 8, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.