Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@coverbeck
Copy link
Contributor

@coverbeck coverbeck commented Jul 13, 2023

Description
Uses a common action instead of replicating script in Java repos.

Also fixed a flaky test, where server-side logging got mixed in with CLI output.

Review Instructions
Verify license check is being done in GitHub actions.

Issue
SEAB-5634

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@coverbeck coverbeck self-assigned this Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.64 🎉

Comparison is base (4e3aeb2) 69.75% compared to head (15b9ccf) 70.39%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #250      +/-   ##
=============================================
+ Coverage      69.75%   70.39%   +0.64%     
- Complexity      1036     1051      +15     
=============================================
  Files             47       47              
  Lines           6067     6067              
  Branches         799      799              
=============================================
+ Hits            4232     4271      +39     
+ Misses          1481     1451      -30     
+ Partials         354      345       -9     
Flag Coverage Δ
bitbuckettests 9.84% <ø> (ø)
confidentialtooltests 55.69% <ø> (ø)
confidentialworkflowtests 30.50% <ø> (+8.12%) ⬆️
nonconfidentialtests 32.33% <ø> (+0.01%) ⬆️
singularitytests 16.56% <ø> (ø)
unittests 8.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coverbeck coverbeck force-pushed the feature/seab-5634/checklicense branch from ae7b275 to 15b9ccf Compare July 20, 2023 00:10
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coverbeck coverbeck merged commit ab4e6bb into develop Jul 20, 2023
@coverbeck coverbeck deleted the feature/seab-5634/checklicense branch July 20, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.