rename reports to avoid clash #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #242 +/- ##
=============================================
+ Coverage 69.56% 69.59% +0.03%
- Complexity 1051 1067 +16
=============================================
Files 47 47
Lines 6081 6081
Branches 802 802
=============================================
+ Hits 4230 4232 +2
Misses 1516 1516
+ Partials 335 333 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kathy-t
approved these changes
May 31, 2023
2 tasks
coverbeck
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up from dockstore/dockstore-support#469
Noticed https://artifacts.oicr.on.ca/artifactory/collab-release/io/dockstore/reports/ had a mix of stuff from different projects (presumably missed since they aren't actually used for anything and the machine user doesn't have overwrite permissions)
Review Instructions
No change to coverage information
Issue
n/a
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
./mvnw clean install