-
Notifications
You must be signed in to change notification settings - Fork 3
CLI Using Beta TRS API - SEAB-5206 #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportBase: 69.46% // Head: 69.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #226 +/- ##
=============================================
+ Coverage 69.46% 69.59% +0.12%
- Complexity 1043 1061 +18
=============================================
Files 47 47
Lines 6062 6061 -1
Branches 801 801
=============================================
+ Hits 4211 4218 +7
Misses 1511 1511
+ Partials 340 332 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| try { | ||
| final Metadata metadata = ga4ghApi.metadataGet(); | ||
| final TRSService serviceinfo = ga4ghv20Api.getServiceInfo(); | ||
| final Gson gson = io.cwl.avro.CWL.getTypeSafeCWLToolDocument(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting way to do it, getting a CWL-specific Gson for non-CWL, but was like that and no need to change. :)
Description
Spin off ticket from DOCK-2300 (UI Relying on Beta TRS) this ticket switches from using
TRS 2.0.0-beta.2API toTRS 2.0.0in the CLI. Appears to only be used in theserverMetadata()function, like in the UI, switched from using the/api/ga4gh/v2/metadatacall to/ga4gh/trs/v2/service-info.Output from
--server-metadatabefore:Output from
--server-metadataafter:Review Instructions
Issue
SEAB-5206
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
./mvnw clean install