Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

rotate bundle #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
denis-yuen merged 3 commits into from
Jan 6, 2023
Merged

rotate bundle #213

denis-yuen merged 3 commits into from
Jan 6, 2023

Conversation

@denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Jan 5, 2023 •
edited
Loading

Description
Rotate encrypted bundle

Review Instructions
Circle ci builds should work

Issue
n/a

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Jan 5, 2023
@denis-yuen denis-yuen changed the title test this rotate bundle Jan 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jan 5, 2023 •
edited
Loading

Codecov Report

Base: 69.15% // Head: 69.14% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (de57324) compared to base (c9da66d).
Patch has no changes to coverable lines.

❗ Current head de57324 differs from pull request most recent head b98d094. Consider uploading reports for the commit b98d094 to get more accurate results

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop     #213      +/-   ##
=============================================
- Coverage      69.15%   69.14%   -0.02%     
- Complexity      1032     1033       +1     
=============================================
  Files             46       46              
  Lines           5940     5940              
  Branches         776      776              
=============================================
- Hits            4108     4107       -1     
- Misses          1501     1503       +2     
+ Partials         331      330       -1
Flag Coverage Δ
bitbuckettests 10.01% <ø> (ø)
confidentialtooltests 53.51% <ø> (-0.11%) ⬇️
confidentialworkflowtests 28.38% <ø> (-0.02%) ⬇️
nonconfidentialtests 32.86% <ø> (-0.06%) ⬇️
singularitytests 16.90% <ø> (ø)
unittests 8.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/io/github/collaboratory/wdl/WDLClient.java 79.20% <0.00%> (-1.00%) ⬇️
...ain/java/io/dockstore/common/FileProvisioning.java 70.24% <0.00%> (-0.93%) ⬇️
...in/java/io/github/collaboratory/cwl/CWLClient.java 80.07% <0.00%> (-0.36%) ⬇️
...ava/io/dockstore/client/cli/nested/ToolClient.java 72.25% <0.00%> (+0.13%) ⬆️
...io/dockstore/client/cli/nested/WorkflowClient.java 73.54% <0.00%> (+0.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@denis-yuen denis-yuen marked this pull request as ready for review January 5, 2023 18:56
@denis-yuen denis-yuen requested review from a team, coverbeck, david4096, hyunnaye and kathy-t and removed request for a team January 5, 2023 18:56
kathy-t
kathy-t approved these changes Jan 5, 2023
View reviewed changes
encrypt.sh Show resolved Hide resolved
scripts/decrypt.sh Show resolved Hide resolved
@denis-yuen denis-yuen merged commit 67bc34a into develop Jan 6, 2023
@denis-yuen denis-yuen deleted the feature/rotate_bundle branch January 6, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david4096 david4096 Awaiting requested review from david4096 david4096 was automatically assigned from dockstore/dockstore

@hyunnaye hyunnaye Awaiting requested review from hyunnaye hyunnaye was automatically assigned from dockstore/dockstore

2 more reviewers

@coverbeck coverbeck coverbeck approved these changes

@kathy-t kathy-t kathy-t approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@denis-yuen denis-yuen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@denis-yuen @coverbeck @kathy-t
Morty Proxy This is a proxified and sanitized view of the page, visit original site.