Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

clear out a few dependencies #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
denis-yuen merged 3 commits into from
Nov 15, 2022
Merged

clear out a few dependencies #205

denis-yuen merged 3 commits into from
Nov 15, 2022

Conversation

@denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Nov 14, 2022 •
edited
Loading

Description
Clear out a few dependency updates, helps sort out which ones we want to keep

Review Instructions
Probably doesn't require review

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5001

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Nov 14, 2022
@denis-yuen denis-yuen marked this pull request as ready for review November 14, 2022 22:58
@denis-yuen denis-yuen requested review from a team, coverbeck, david4096 and hyunnaye and removed request for a team November 14, 2022 22:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 14, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 14, 2022 •
edited
Loading

Codecov Report

Base: 68.57% // Head: 68.34% // Decreases project coverage by -0.23% ⚠️

Coverage data is based on head (3325aa5) compared to base (4789745).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #205      +/-   ##
===========================================
- Coverage    68.57%   68.34%   -0.24%     
===========================================
  Files           49       49              
  Lines         6011     6014       +3     
  Branches       792      793       +1     
===========================================
- Hits          4122     4110      -12     
- Misses        1570     1574       +4     
- Partials       319      330      +11
Flag Coverage Δ
bitbuckettests 9.89% <0.00%> (-0.01%) ⬇️
confidentialtooltests 53.58% <25.00%> (-0.22%) ⬇️
confidentialworkflowtests 28.43% <25.00%> (-0.05%) ⬇️
nonconfidentialtests 32.77% <0.00%> (-0.14%) ⬇️
singularitytests 16.69% <0.00%> (-0.01%) ⬇️
unittests 8.06% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ava/io/dockstore/client/cli/YamlVerifyUtility.java 92.30% <100.00%> (-2.36%) ⬇️
...in/java/io/github/collaboratory/wdl/WDLClient.java 79.20% <0.00%> (-1.00%) ⬇️
...ain/java/io/dockstore/common/FileProvisioning.java 70.24% <0.00%> (-0.93%) ⬇️
...ckstore/client/cli/nested/AbstractEntryClient.java 73.50% <0.00%> (-0.50%) ⬇️
...io/dockstore/client/cli/nested/WorkflowClient.java 74.04% <0.00%> (-0.31%) ⬇️
.../src/main/java/io/dockstore/client/cli/Client.java 48.14% <0.00%> (-0.25%) ⬇️
...in/java/io/github/collaboratory/cwl/CWLClient.java 80.28% <0.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@denis-yuen denis-yuen requested a review from svonworl November 15, 2022 15:06
@denis-yuen
Copy link
Member Author

denis-yuen commented Nov 15, 2022

adding @svonworl , think some of the changes are due to dockstore/dockstore#5212

@denis-yuen denis-yuen merged commit abe8514 into develop Nov 15, 2022
@denis-yuen denis-yuen deleted the feature/bom-update branch November 15, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svonworl svonworl svonworl approved these changes

@david4096 david4096 Awaiting requested review from david4096 david4096 was automatically assigned from dockstore/dockstore

+2 more reviewers

@coverbeck coverbeck coverbeck approved these changes

@hyunnaye hyunnaye hyunnaye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@denis-yuen denis-yuen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@denis-yuen @coverbeck @hyunnaye @svonworl
Morty Proxy This is a proxified and sanitized view of the page, visit original site.