Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Sep 15, 2022

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install

@denis-yuen denis-yuen self-assigned this Sep 15, 2022
@denis-yuen denis-yuen requested review from a team, coverbeck, david4096, hyunnaye and kathy-t and removed request for a team September 15, 2022 15:23
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 68.32% // Head: 68.09% // Decreases project coverage by -0.23% ⚠️

Coverage data is based on head (a2845a5) compared to base (95bb9df).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #187      +/-   ##
===========================================
- Coverage    68.32%   68.09%   -0.24%     
===========================================
  Files           49       49              
  Lines         6011     6011              
  Branches       792      792              
===========================================
- Hits          4107     4093      -14     
- Misses        1578     1580       +2     
- Partials       326      338      +12     
Flag Coverage Δ
bitbuckettests 9.89% <ø> (ø)
confidentialtooltests 53.45% <ø> (-0.04%) ⬇️
confidentialworkflowtests 28.29% <ø> (-0.14%) ⬇️
nonconfidentialtests 32.73% <ø> (-0.09%) ⬇️
singularitytests 16.70% <ø> (ø)
unittests 8.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...io/dockstore/client/cli/nested/WorkflowClient.java 72.36% <0.00%> (-1.53%) ⬇️
...in/java/io/github/collaboratory/wdl/WDLClient.java 79.20% <0.00%> (-1.00%) ⬇️
.../src/main/java/io/dockstore/client/cli/Client.java 46.91% <0.00%> (-0.99%) ⬇️
...ckstore/client/cli/nested/AbstractEntryClient.java 73.60% <0.00%> (-0.41%) ⬇️
...in/java/io/github/collaboratory/cwl/CWLClient.java 80.10% <0.00%> (-0.18%) ⬇️
...in/java/io/dockstore/common/FileProvisionUtil.java 75.42% <0.00%> (+3.38%) ⬆️
...sted/notificationsclients/NotificationsClient.java 82.35% <0.00%> (+3.92%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@denis-yuen denis-yuen marked this pull request as ready for review September 15, 2022 15:45
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@svonworl
Copy link
Contributor

Why no "Issue" section?

@denis-yuen denis-yuen requested a review from svonworl September 15, 2022 19:45
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@denis-yuen denis-yuen merged commit f487fcd into develop Sep 16, 2022
@denis-yuen denis-yuen deleted the feature/pr_template_docs branch September 16, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.