Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

tranquillity-codes
Copy link
Contributor

Description

Changing his to their

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

Note

I was unable to figure out what format the CHANGELOG.md file should be in, here is my best guess. There's also no point of contact to the dev team, normally I'd just email a patch...

Copy link
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: 451a35d

@casperklein
Copy link
Member

Thanks!

There's also no point of contact to the dev team, normally I'd just email a patch...

What's wrong with opening a PR, like you did?

@casperklein casperklein merged commit 8ca2bd2 into docker-mailserver:master Mar 18, 2025
3 checks passed
@tranquillity-codes
Copy link
Contributor Author

What's wrong with opening a PR, like you did?

I spent 30 minutes attempting to figure out how to do it properly haha, GitHub UI is very confusing to me compared to git format-patch

Thanks for the merge ^^

@polarathene
Copy link
Member

Is this a change worth having in the changelog itself? It looks rather small and wouldn't have much relevance to most users looking over what changed? It's similar to a typo or URL fix in that sense.

I spent 30 minutes attempting to figure out how to do it properly haha

Usually you can just click the "fork" button on the top-right of a repo and clone that to make changes, then you commit your change locally and push it back to your fork and when you visit the origin repo on Github it'll notice your fork had a change recently and show you a green button to open a PR for it.

Alternatively when it is just a single file change you can view the file in our repo and click the pencil icon near the top-right of the page to do an edit as well. When you save changes it'll fork the repo if necessary and switch you straight to the PR screen :)

Not knowing about either of those methods, it'd be a bit more steps 😅

@polarathene polarathene added kind/improvement Improve an existing feature, configuration file or the documentation area/documentation labels Mar 18, 2025
@polarathene polarathene added this to the v15.0.1 milestone Mar 18, 2025
@tranquillity-codes
Copy link
Contributor Author

Thanks ^^

I wasn't sure if I should put it in the changelog or not, the PR template seemed to be really insistent on it so I have, and I wasn't able to find any documentation for when to include something in the changelog or not so I made a best-effort guess ^^"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.