-
-
Notifications
You must be signed in to change notification settings - Fork 2k
chore: Revise utility install scripts + add Smallstep step
CLI
#4376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jaq
to /usr/local/bin
+ install swaks
via tar
step
CLI
No need to cram this into v15.0.0. I also lack background for this change, it seems. What's the rationale here? |
For I think it's a more user friendly As such it can replace the separate opendkim/rspamd DKIM key generators. Your rspamd script for example appears to start rspamd in the background just to generate the keys. We could technically not add Or were you asking about the other changes unrelated to |
Sorry, I was blind I guess... I somehow missed it in the PR description. I really like these modern tools! And I also appreciate this replacing the horrible |
LGTM 👍 If there are more tools in the future, we should put them in own functions. |
IMO we can put this into v15.0.1 too @polarathene if you update |
Description
step
isn't used for anything yet, so no rush for this PR, but it won't introduce any breakage into DMS v15 😅Changes:
jaq
should probably live in/usr/local/bin
with other third-party sourced binaries.swaks
install properly with justtar
, nomv
+rm
needed.step
CLI. This serves similar purpose toopenssl
commands, but is generally nicer for usage with generation and inspection of certs/keys. I've talked up using in DMS a few times in the past for our TLS helper and unifying DKIM support (instead of separate OpenDKIM/Rspamd generators).step
for both AMD64 / ARM64 archs needs the alternate naming convention that it's published to GH releases with.tar
usage. The ownership is a common one, technically a non-issue when running asroot
🤷♂️ Let me know if it's overkill and you prefer themv
+rm
approach with a additionalchown
.Type of change
Checklist
CHANGELOG.md