Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore: remove VERSION file #4321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2025
Merged

chore: remove VERSION file #4321

merged 3 commits into from
Jan 19, 2025

Conversation

georglauterbach
Copy link
Member

Description

Fixes #3677

ref #4302

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@georglauterbach
chore: remove VERSION file
33ec857 
Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
@georglauterbach georglauterbach added priority/medium area/configuration (file) kind/update Update an existing feature, configuration file or the documentation labels Jan 18, 2025
@georglauterbach georglauterbach added this to the v15.0.0 milestone Jan 18, 2025
@georglauterbach georglauterbach self-assigned this Jan 18, 2025
@georglauterbach
Copy link
Member Author

GitHub does not seem to run the CI against the merged changes, hence CI fails. I can merge with administrator privileges if you think these changes are fine @casperklein @polarathene.

polarathene
polarathene previously approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub does not seem to run the CI against the merged changes, hence CI fails.

Yeah we have the CI workflow pointing at the latest master branch commit for reusable workflows like the image build or tests (it's only the workflow part, they'll use the PR branch for building/testing).

LGTM! 👍

casperklein
casperklein reviewed Jan 18, 2025
View reviewed changes
.github/workflows/generic_build.yml Outdated Show resolved Hide resolved
@georglauterbach @casperklein
Update generic_build.yml
236e373 
Co-authored-by: Casper <casperklein@users.noreply.github.com>
@georglauterbach georglauterbach merged commit f0daa1c into master Jan 19, 2025
3 of 4 checks passed
@georglauterbach georglauterbach deleted the gl/remove-version branch January 19, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein left review comments

@polarathene polarathene polarathene left review comments

Assignees

@georglauterbach georglauterbach

Labels

area/configuration (file) kind/update Update an existing feature, configuration file or the documentation priority/medium

Projects

None yet

Milestone

v15.0.0

Development

Successfully merging this pull request may close these issues.

[TODO]: Remove VERSION

3 participants

@georglauterbach @casperklein @polarathene
Morty Proxy This is a proxified and sanitized view of the page, visit original site.