-
-
Notifications
You must be signed in to change notification settings - Fork 2k
breaking: Drop Dovecot support for Solr #4025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Testing is in progress |
Dang it, I accidentally added my other PR into this one. Will fix as soon as the tests finish. |
Solr now uses a 2yo image in DMS available only for the amd64 architecture. Using the official Solr 9 imagage creates many issues when importing the necessary files (dovecot config and schema). Since this issue hasn't been noticed for a long time it's assumed that Solr has little to no use amongst DMS users. BREAKING CHANGE: Solr setup will no longer be working. Use Xapian instead.
I have x failed tests:
|
You forgot to update the |
Dang it. I messed up some commits and reverted that one by accident. Forgot to add it back. Will do in the next 40 minutes |
The wording isn't the best but it gets the message across (keep in mind that it's 11pm here so I'm tired). I'm open to suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides potentially removing a line on the FTS docs page, LGTM 👍
I revised and relocated the changelog item.
Documentation preview for this PR is ready! 🎉 Built with commit: e51869d |
Too bad, really loved this feature. With large mailboxes this litterly makes the difference between snappy mail search and no mail search at all :/ Guess I will have a look at Xapian then :) |
Does Xapian not accomplish the same? The future successor (flatcurve I think?) is also meant to be a better replacement AFAIK. Solr support can be restored if someone is willing to contribute the requirements (as per the changelog entry). Realistically though, if you look at what was removed, it really is just a single package The docs are not helpful, so they've been dropped. No maintainer is able to assist / support with Solr issues either, so it makes sense for us to drop it officially. |
Thx! Used Xapian before and the non server part is a bonus I guess. Seems single threaded though and is indexing for more then a day now, however it does seem to work. Will look in getting solr to work again if I can find some time for that :) |
In the end xapian took like 3 days (!) to finish and start offering fts on clients like gmail. Its index had grew to 20+ GB ... so I decided to give solr one more go as I could recall it to grow that big or take such an insane amount of time to finish the initial indexing. This post proved to be rather useful: https://cyclops.nettrends.nl/blog/2023/09/dovecot-with-apache-solr-in-docker-with-ssl/ Of course it wasn't as simple as just using solr 9 Building Mailserver with In the end mailserver+solr took a couple of minutes and about 1.6GB to index my insanely big inbox. After that I could search on my mobile for specific keywords in the big pile of e-mail near instantly where searching without dovecot fts is simply not possible, it just timeouts. I strongly urge you to reconsider this decision, still consider myself a novice on docker container building and all of this just took my an hour or so, mostly on figuring out the missing parts. |
You can contribute a community guide to our docs. The only integration DMS really did was include a plugin. Since we already include a Dovecot plugin for a Lua-based community guide, I'd be open to accepting this. The only rule we have then is that provided the plugin does not negatively affect maintenance, it should be fine to include it. My main concern is we can't officially support it, since no maintainer has a need for Solr, nor interest in keeping documentation relevant (which is why we dropped it with v14, docs were terribly outdated). For the few users that do bother to setup Solr because they have a need for it, it's a few lines for you to add the plugin in Show your support / interest for Another user shared their approach to getting Solr working with DMS. I wasn't fond of it as it did not seem like it would age well as a guide in the docs, so you contribute something to the docs and that becomes outdated like the previous guide that no one updated or raised issue with for years, we would likely drop it again 🤷♂️ If enough users show interest for |
It would be great if you could just include dovecot-solr in your build process and nothing more. As long as one does not load the solr plugin via config it should not touch or affect anything. Imho the method I used now is future proof:
Will write a support doc then. After all it didn't took that much. |
I have tried setting up Solar in a Kubernetes cluster yesterday, and I can confidently say this is nothing we can maintain at all [1]. I appreciate the documentation PR, and we will definitely merge it (after all the feedback has been addressed). Installing [1]
|
I understand, not being able to provide an arm64 build these days is problematic. Pitty. |
Is there a reason that my suggestion to add the package via It's really not much friction for a user that wants to setup Solr?: services:
dms:
hostname: mail.example.test
# Do not use `image` anymore, unless referring to the tag below
# Add this build section to your real `compose.yaml`:
build:
tags:
- local/dms:14.0
dockerfile_inline: |
FROM docker.io/mailserver/docker-mailserver:14.0
RUN apt-get update && apt-get install dovecot-solr Running When you want to update, instead of changing the
|
Great tip about the compose.yml edit, just tried is add it works like a charm. Learned a new trick today 👍 :D |
Description
Solr now uses a 2yo image in DMS available only for the amd64 architecture.
Using the official Solr 9 imagage creates many issues when importing the necessary files (dovecot config and schema).
Since this issue hasn't been noticed for a long time it's assumed that Solr has little to no use amongst DMS users.
BREAKING CHANGE: Solr setup will no longer be working. Use Xapian instead.
Fixes #4024
Type of change
Checklist
docs/
)CHANGELOG.md