Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

georglauterbach
Copy link
Member

@georglauterbach georglauterbach commented Mar 5, 2024

Description

Pinning the Rspamd is not something I want to do for now. DMS will ship 3.8.4 on :edge.

This change alters the Redis history key to not have the hostname, which easily changes in Kubernetes, in the Redis history key to keep the Redis history across pod restarts. This is a breaking change, as the Redis history might (and very likely will) be lost when upgrading.

Fixes #3922

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@georglauterbach georglauterbach added kind/improvement Improve an existing feature, configuration file or the documentation area/configuration (file) service/security/rspamd labels Mar 5, 2024
@georglauterbach georglauterbach self-assigned this Mar 5, 2024
@georglauterbach georglauterbach added this to the v14.0.0 milestone Mar 5, 2024
Copy link

@cfis cfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks!

@georglauterbach georglauterbach merged commit e21e5e0 into master Mar 6, 2024
@georglauterbach georglauterbach deleted the rspamd/redis-history-keys branch March 6, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/configuration (file) kind/improvement Improve an existing feature, configuration file or the documentation service/security/rspamd

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.