Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

getmail: remove temp file usage #3920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 9, 2024
Merged

getmail: remove temp file usage #3920

merged 6 commits into from
Mar 9, 2024

Conversation

casperklein
Copy link
Member

@casperklein casperklein commented Mar 3, 2024 •
edited
Loading

Description

I stumbled across this and wondered why a temp file was being used.

@LucidityCrash Can you check/confirm, if that change is fine?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@casperklein casperklein self-assigned this Mar 3, 2024
@casperklein casperklein marked this pull request as ready for review March 3, 2024 22:07
@casperklein casperklein added kind/improvement Improve an existing feature, configuration file or the documentation area/scripts labels Mar 3, 2024
@casperklein casperklein added this to the v14.0.0 milestone Mar 3, 2024
@casperklein casperklein changed the title Refactor getmail getmail: remove temp file usage Mar 3, 2024
@LucidityCrash
Copy link
Contributor

Yeah I don't see why that would cause an issue ... no idea why I used a temp file in the first place.

georglauterbach
georglauterbach previously approved these changes Mar 4, 2024
View reviewed changes
polarathene
polarathene previously approved these changes Mar 5, 2024
View reviewed changes
@casperklein casperklein dismissed stale reviews from georglauterbach and polarathene via 459aa50 March 9, 2024 11:24
@casperklein casperklein enabled auto-merge (squash) March 9, 2024 11:25
@casperklein casperklein merged commit 267fc55 into docker-mailserver:master Mar 9, 2024
@casperklein casperklein deleted the simplify-getmail branch March 16, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georglauterbach georglauterbach georglauterbach approved these changes

@polarathene polarathene Awaiting requested review from polarathene

Assignees

@casperklein casperklein

Labels

area/scripts kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Milestone

v14.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@casperklein @LucidityCrash @polarathene @georglauterbach
Morty Proxy This is a proxified and sanitized view of the page, visit original site.