Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

aspettl
Copy link
Contributor

@aspettl aspettl commented Jan 31, 2024

Description

For rspamd, when setting sign_local = true; in dkim_signing.conf, I expect that normal internal IP addresses are "local" by default. Looking at options.inc, however, you can see that a comma is missing between the last two IP blocks. So the intention is clearly there, but it does not work.

This PR adds the comma. Mails sent from an IP in 192.168.. are now signed on my system, which did not work before.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@aspettl aspettl changed the title Add missing comma to rspamd local_networks configuration rspamd: add missing comma to local_networks configuration Jan 31, 2024
@polarathene polarathene added this to the v14.0.0 milestone Jan 31, 2024
@polarathene polarathene changed the title rspamd: add missing comma to local_networks configuration fix(rspamd): Add missing comma to local_networks setting Jan 31, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@georglauterbach georglauterbach merged commit 05fbcf6 into docker-mailserver:master Jan 31, 2024
@aspettl aspettl deleted the fix-rspamd-local-networks branch January 31, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.