Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

tests: small adjustments #3772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 14, 2024
Merged

tests: small adjustments #3772

merged 4 commits into from
Jan 14, 2024

Conversation

georglauterbach
Copy link
Member

@georglauterbach georglauterbach commented Jan 11, 2024 •
edited
Loading

Description

I wanted #3747 to be merged because the discussion became quite lengthy. This PR covers the last little pieces of feedback that I discovered and that can get fixed quite easily. Feel free to introduce your ideas too.

Fixes #

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@georglauterbach
remove dead code from sending.bash
59e022d
@georglauterbach
unify the sending of spam e-mails
f4ce9c8 
A new short helper `_send_spam` was introduced, which uses the GTUBE
pattern and `_send_email_and_get_id` under the hood. This eases sending
spam and gets rid of another e-mail template.
@georglauterbach georglauterbach added area/tests kind/improvement Improve an existing feature, configuration file or the documentation labels Jan 11, 2024
@georglauterbach georglauterbach added this to the v14.0.0 milestone Jan 11, 2024
@georglauterbach georglauterbach self-assigned this Jan 11, 2024
polarathene
polarathene approved these changes Jan 14, 2024
View reviewed changes
Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Sorry for the review delay 😅

@georglauterbach georglauterbach merged commit 3a142f9 into master Jan 14, 2024
@georglauterbach georglauterbach deleted the tests/more-comments branch January 14, 2024 22:14
@georglauterbach georglauterbach modified the milestones: v14.0.0, v13.3.0 Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@casperklein casperklein Awaiting requested review from casperklein

Assignees

@georglauterbach georglauterbach

Labels

area/tests kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Milestone

v13.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@georglauterbach @polarathene
Morty Proxy This is a proxified and sanitized view of the page, visit original site.