Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

polarathene
Copy link
Member

@polarathene polarathene commented Jan 5, 2024

Description

This was always configured disabled at runtime, better to just set explicitly in main.cf unless config diverges when Dovecot is enabled to opt-out of this feature.

The related test now ensures that we're refuting against the expected output returned. The refute alone would still pass if the command wasn't returning the correct output to check against.

Feature reference

This feature still does not appear to have compatibility with Dovecot. References:

Reproduction

FWIW, I could not seem to reproduce failure regardless of this setting be enabled or not.

  • I tried sending mail with swaks within the same DMS container and PERMIT_DOCKER=container on port 465 authenticated which perhaps bypassed the issue.
  • Both times the logs seem to suggest that Dovecot was accepting the mail over LMTP and storing it, despite using a subject line with UTF8 value. Not sure if swaks or the terminal affected that (the terminal WSL2 did not play well with editing content after these multi-byte graphemes were pasted 😅 )

If someone believes this feature is working properly and should be enabled, submit a test-case which can trigger the failure you experience with this setting disabled, and another test-case where it correctly delivers the mail with the setting enabled (use our postfix-main.cf override support).

UTF8 in the subject line presumably failed in the past at least.

UPDATE: Read the Postfix limitations again, local-part UTF8 in the envelope sender/receiver is ok, but not the domain-part (subject to DNS). This fails even with smtputf8_enable = yes

=== Trying 0.0.0.0:465...
=== Connected to 0.0.0.0.
<-  220 mail.example.test ESMTP
 -> EHLO external.test
<-  250-mail.example.test
<-  250-PIPELINING
<-  250-SIZE 10240000
<-  250-ETRN
<-  250-AUTH PLAIN LOGIN
<-  250-AUTH=PLAIN LOGIN
<-  250-ENHANCEDSTATUSCODES
<-  250-8BITMIME
<-  250-DSN
<-  250-SMTPUTF8
<-  250 CHUNKING
 -> AUTH LOGIN
<-  334 VXNlcm5hbWU6
 -> aGVsbG9AZXhhbXBsZS50ZXN0
<-  334 UGFzc3dvcmQ6
 -> YmFkLXBhc3N3b3Jk
<-  235 2.7.0 Authentication successful
 -> MAIL FROM:<someone@💩.test>
<** 501 5.1.7 Bad sender address syntax
 -> QUIT
<-  221 2.0.0 Bye
=== Connection closed with remote host.

Logs related to that differed by setting on/off:

# smtputf8_enable = yes
Jan  5 05:43:35 original postfix/submissions/smtpd[16866]: warning: Illegal address syntax from localhost[127.0.0.1] in MAIL command: <someone@💩.test>

# smtputf8_enable = no
Jan  5 05:44:36 original postfix/submissions/smtpd[17156]: warning: Illegal address syntax from localhost[127.0.0.1] in MAIL command: <someone@????.test>

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

This was always configured disabled at runtime, better to just set explicitly in `main.cf` unless config diverges when Dovecot is enabled to opt-out of this feature.
@polarathene polarathene added service/postfix area/tests kind/improvement Improve an existing feature, configuration file or the documentation area/configuration (file) labels Jan 5, 2024
@polarathene polarathene added this to the v14.0.0 milestone Jan 5, 2024
@polarathene polarathene self-assigned this Jan 5, 2024
georglauterbach
georglauterbach previously approved these changes Jan 5, 2024
casperklein
casperklein previously approved these changes Jan 5, 2024
@polarathene polarathene enabled auto-merge (squash) January 5, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/configuration (file) area/tests kind/improvement Improve an existing feature, configuration file or the documentation service/postfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.