chore: Disable smtputf8
support in config directly
#3750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was always configured disabled at runtime, better to just set explicitly in
main.cf
unless config diverges when Dovecot is enabled to opt-out of this feature.The related test now ensures that we're refuting against the expected output returned. The refute alone would still pass if the command wasn't returning the correct output to check against.
Feature reference
This feature still does not appear to have compatibility with Dovecot. References:
SMTPUTF8
docs (has a limitations section, it can advertise support but it is not complete): https://www.postfix.org/SMTPUTF8_README.htmlReproduction
FWIW, I could not seem to reproduce failure regardless of this setting be enabled or not.
PERMIT_DOCKER=container
on port 465 authenticated which perhaps bypassed the issue.swaks
or the terminal affected that (the terminal WSL2 did not play well with editing content after these multi-byte graphemes were pasted 😅 )If someone believes this feature is working properly and should be enabled, submit a test-case which can trigger the failure you experience with this setting disabled, and another test-case where it correctly delivers the mail with the setting enabled (use our
postfix-main.cf
override support).UTF8 in the subject line presumably failed in the past at least.
UPDATE: Read the Postfix limitations again, local-part UTF8 in the envelope sender/receiver is ok, but not the domain-part (subject to DNS). This fails even with
smtputf8_enable = yes
Logs related to that differed by setting on/off:
Type of change
Checklist:
CHANGELOG.md