Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add warning, when update-check is enabled, but no stable release image is used #3684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2023
Merged

Add warning, when update-check is enabled, but no stable release image is used #3684

merged 3 commits into from
Dec 5, 2023

Conversation

casperklein
Copy link
Member

@casperklein casperklein commented Dec 5, 2023 •
edited
Loading

Description

This PR adds a warning, when update-check is enabled, but no stable release image is used.

Related: #3666

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@casperklein casperklein marked this pull request as ready for review December 5, 2023 17:23
@casperklein casperklein self-assigned this Dec 5, 2023
@casperklein casperklein added the kind/improvement Improve an existing feature, configuration file or the documentation label Dec 5, 2023
@casperklein casperklein added this to the v13.1.0 milestone Dec 5, 2023
polarathene
polarathene previously approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! 😁

CHANGELOG.md Outdated Show resolved Hide resolved
georglauterbach
georglauterbach previously approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

CHANGELOG.md Outdated Show resolved Hide resolved
@georglauterbach georglauterbach dismissed stale reviews from polarathene and themself via 2fc60ce December 5, 2023 20:41
@georglauterbach georglauterbach enabled auto-merge (squash) December 5, 2023 20:42
@georglauterbach georglauterbach merged commit 908d380 into docker-mailserver:master Dec 5, 2023
@casperklein casperklein deleted the update-check-edge branch December 7, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georglauterbach georglauterbach georglauterbach approved these changes

@polarathene polarathene polarathene left review comments

Assignees

@casperklein casperklein

Labels

area/scripts kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Milestone

v13.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@casperklein @polarathene @georglauterbach
Morty Proxy This is a proxified and sanitized view of the page, visit original site.