Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Support customizing the default network for a stack #31258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2017
Merged

Support customizing the default network for a stack #31258

merged 1 commit into from
Mar 7, 2017

Conversation

dnephin
Copy link
Member

@dnephin dnephin commented Feb 22, 2017

Fixes #31228

@dnephin dnephin force-pushed the fix-override-default-stack-network branch 2 times, most recently from 5949a5f to 35c53d7 Compare February 22, 2017 18:59
@dnephin
Support customizing the default network for a stack.
b7577dd 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@dnephin dnephin force-pushed the fix-override-default-stack-network branch from 35c53d7 to b7577dd Compare February 24, 2017 22:32
@dnephin
Copy link
Member Author

dnephin commented Mar 3, 2017

ping @vdemeester

vdemeester
vdemeester approved these changes Mar 3, 2017
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

cpuguy83
cpuguy83 approved these changes Mar 7, 2017
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit dd221a1 into moby:master Mar 7, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.04.0 milestone Mar 7, 2017
@dnephin dnephin deleted the fix-override-default-stack-network branch March 7, 2017 19:44
@thaJeztah thaJeztah modified the milestones: 17.03.1, 17.04.0 Mar 7, 2017
@thaJeztah thaJeztah mentioned this pull request Mar 20, 2017
Closed
@thaJeztah
Copy link
Member

cherry-picked into 17.03.1 through #31754

dnephin pushed a commit to dnephin/docker that referenced this pull request Apr 17, 2017
@cpuguy83
Merge pull request moby#31258 from dnephin/fix-override-default-stack…
f6f52d0 
…-network

Support customizing the default network for a stack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

+1 more reviewer

@vdemeester vdemeester vdemeester approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vieux vieux

Labels

impact/changelog process/cherry-picked status/2-code-review

Projects

None yet

Milestone

17.03.1

Development

Successfully merging this pull request may close these issues.

6 participants

@dnephin @thaJeztah @vdemeester @cpuguy83 @vieux @GordonTheTurtle
Morty Proxy This is a proxified and sanitized view of the page, visit original site.