Fix cpu spin waiting for log write events #31070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
LK4D4
reviewed
Feb 16, 2017
daemon/logger/jsonfilelog/read.go
Outdated
There was a problem hiding this comment.
this construction looks extremely confusing for me, why don't just use for {} and do stuff inside?
There was a problem hiding this comment.
Yep, makes sense.
Updated.
This loop is not ever going to return since it's never actually setting the `err` var except on the first iteration. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
229d77b to
7a17997
Compare
|
This is ready. |
thaJeztah
pushed a commit
to thaJeztah/docker
that referenced
this pull request
Feb 18, 2017
Fix cpu spin waiting for log write events (cherry picked from commit 39851ea) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This loop is not ever going to return since it's never actually setting
the
errvar except on the first iteration.Fixes #31060