Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

update github.com/spf13/cobra v1.10.2, switch to go.yaml.in/yaml/v3#71

Merged
thaJeztah merged 1 commit intodocker:maindocker/cli-docs-tool:mainfrom
thaJeztah:bump_cobra_yamlthaJeztah/cli-docs-tool:bump_cobra_yamlCopy head branch name to clipboard
Dec 9, 2025
Merged

update github.com/spf13/cobra v1.10.2, switch to go.yaml.in/yaml/v3#71
thaJeztah merged 1 commit intodocker:maindocker/cli-docs-tool:mainfrom
thaJeztah:bump_cobra_yamlthaJeztah/cli-docs-tool:bump_cobra_yamlCopy head branch name to clipboard

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Dec 9, 2025

Only remaining use is in testifiy, which has a pending PR to switch

Only remaining use is in testifiy, which has a pending PR to switch

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to update dependencies including upgrading github.com/spf13/cobra from v1.8.1 to v1.10.2 and switching the YAML library import path. However, there is a critical issue: the PR incorrectly uses go.yaml.in/yaml/v3 as the module path instead of the correct gopkg.in/yaml.v3.

Key Changes:

  • Updates github.com/spf13/cobra from v1.8.1 to v1.10.2
  • Updates github.com/spf13/pflag from v1.0.5 to v1.0.10
  • Incorrectly attempts to switch from gopkg.in/yaml.v3 to go.yaml.in/yaml/v3 (this is an invalid module path)

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
go.mod Updates cobra and pflag versions; incorrectly adds go.yaml.in/yaml/v3 instead of gopkg.in/yaml.v3
go.sum Adds checksums for updated dependencies including the incorrect go.yaml.in/yaml/v3 module
clidocstool_yaml.go Updates import to use incorrect go.yaml.in/yaml/v3 path
example/go.mod Reflects dependency updates with incorrect yaml module path
example/go.sum Adds checksums for updated dependencies including incorrect yaml module

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread go.mod
Comment thread clidocstool_yaml.go
Comment thread example/go.mod
@thaJeztah thaJeztah requested a review from vvoland December 9, 2025 12:16
@thaJeztah
Copy link
Copy Markdown
Member Author

Thx! I'll have a look at updating some other dependencies in the examples/, and update go-md2man to the current version (but less critical)

@thaJeztah thaJeztah merged commit a348444 into docker:main Dec 9, 2025
12 checks passed
@thaJeztah thaJeztah deleted the bump_cobra_yaml branch December 9, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.