image/tree: Respect NO_COLOR env variable #6654
Merged
+46
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
robmry
approved these changes
Nov 13, 2025
thaJeztah
approved these changes
Nov 13, 2025
Member
thaJeztah
left a comment
There was a problem hiding this comment.
changes LGTM - two small comments
a823ef6 to
553b1a3
Compare
Do not use the fancy colored output if NO_COLOR variable is set to 1 following the https://no-color.org/ convention. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
553b1a3 to
be9e630
Compare
austinvazquez
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO_COLORin the output of docker commands (specifically docker images) #6653Do not use the fancy colored output if NO_COLOR variable is set to 1 following the https://no-color.org/ convention.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)