Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bash completion for service ps supports multiple services#395

Merged
mlaventure merged 1 commit intodocker:masterdocker/cli:masterfrom
albers:completion-service-ps-multiplealbers/docker-cli:completion-service-ps-multipleCopy head branch name to clipboard
Aug 2, 2017
Merged

bash completion for service ps supports multiple services#395
mlaventure merged 1 commit intodocker:masterdocker/cli:masterfrom
albers:completion-service-ps-multiplealbers/docker-cli:completion-service-ps-multipleCopy head branch name to clipboard

Conversation

@albers
Copy link
Copy Markdown
Collaborator

@albers albers commented Jul 28, 2017

docker service ps was changed to support multiple services in moby/moby#25234.
Ping @sdurrheimer for zsh completion

Signed-off-by: Harald Albers <github@albersweb.de>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 28, 2017

Codecov Report

Merging #395 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   46.17%   46.17%           
=======================================
  Files         193      193           
  Lines       16081    16081           
=======================================
  Hits         7425     7425           
  Misses       8269     8269           
  Partials      387      387

Copy link
Copy Markdown
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Copy link
Copy Markdown
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlaventure mlaventure merged commit c4d705f into docker:master Aug 2, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.08.0 milestone Aug 2, 2017
@albers albers deleted the completion-service-ps-multiple branch August 2, 2017 20:40
@thaJeztah thaJeztah modified the milestones: 17.06.1, 17.08.0 Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.