Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: fix double subscriptable error #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2023
Merged

fix: fix double subscriptable error #1800

merged 3 commits into from
Sep 27, 2023

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Sep 19, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (dce3907) 84.12% compared to head (ddd013c) 84.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1800      +/-   ##
==========================================
+ Coverage   84.12%   84.13%   +0.01%     
==========================================
  Files         135      135              
  Lines        8906     8908       +2     
==========================================
+ Hits         7492     7495       +3     
+ Misses       1414     1413       -1     
Flag Coverage Δ
docarray 84.13% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
docarray/array/doc_list/doc_list.py 87.30% <100.00%> (+0.20%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/units/array/test_array.py Outdated Show resolved Hide resolved
@JoanFM JoanFM force-pushed the fix-double-subscriptable branch from 1e90e6d to 2ab4f9d Compare September 20, 2023 19:34
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
@JoanFM JoanFM force-pushed the fix-double-subscriptable branch from 2ab4f9d to fc41eb0 Compare September 20, 2023 19:39
Signed-off-by: Joan Fontanals <joan.martinez@jina.ai>
@github-actions
Copy link

📝 Docs are deployed on https://ft-fix-double-subscriptable--jina-docs.netlify.app 🎉

@JoanFM JoanFM merged commit 7209b78 into main Sep 27, 2023
@JoanFM JoanFM deleted the fix-double-subscriptable branch September 27, 2023 15:45
@JoanFM JoanFM mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Already parametrized DocList class should not be subscriptable
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.