Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bfac093

Browse filesBrowse files
author
Joan Fontanals
authored
test: remove skips (#1809)
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
1 parent 4a1bc26 commit bfac093
Copy full SHA for bfac093

File tree

Expand file treeCollapse file tree

3 files changed

+0
-7
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+0
-7
lines changed

‎tests/units/array/test_array_from_to_pandas.py

Copy file name to clipboardExpand all lines: tests/units/array/test_array_from_to_pandas.py
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
from docarray import BaseDoc, DocList, DocVec
77
from docarray.documents import ImageDoc
88
from docarray.typing import NdArray, TorchTensor
9-
from docarray.utils._internal.pydantic import is_pydantic_v2
109

1110

1211
@pytest.fixture()
@@ -136,7 +135,6 @@ class BasisUnion(BaseDoc):
136135
assert docs_copy == docs_basic
137136

138137

139-
@pytest.mark.skipif(is_pydantic_v2, reason="Not working with pydantic v2")
140138
@pytest.mark.parametrize('tensor_type', [NdArray, TorchTensor])
141139
def test_from_to_pandas_tensor_type(tensor_type):
142140
class MyDoc(BaseDoc):

‎tests/units/document/test_base_document.py

Copy file name to clipboardExpand all lines: tests/units/document/test_base_document.py
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
from docarray import DocList, DocVec
77
from docarray.base_doc.doc import BaseDoc
88
from docarray.typing import NdArray
9-
from docarray.utils._internal.pydantic import is_pydantic_v2
109

1110

1211
def test_base_document_init():

‎tests/units/util/test_filter.py

Copy file name to clipboardExpand all lines: tests/units/util/test_filter.py
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
from docarray import BaseDoc, DocList
77
from docarray.documents import ImageDoc, TextDoc
8-
from docarray.utils._internal.pydantic import is_pydantic_v2
98
from docarray.utils.filter import filter_docs
109

1110

@@ -244,9 +243,6 @@ def test_logic_filter(docs, dict_api):
244243
assert len(result) == 3
245244

246245

247-
@pytest.mark.skipif(
248-
is_pydantic_v2, reason="Not working with pydantic v2"
249-
) # TextDoc validation with string is not working with pydantic v2
250246
@pytest.mark.parametrize('dict_api', [True, False])
251247
def test_from_docstring(dict_api):
252248
class MyDocument(BaseDoc):

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.