Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore: Prepare new dev branch #8223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 21, 2025
Merged

chore: Prepare new dev branch #8223

merged 18 commits into from
May 21, 2025

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented May 12, 2025 •
edited
Loading

Description

This PR updates the version number to 5.1.0dev0.

It removes deprecated features as announced in django CMS 4.0 and 4.1.

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against main
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

Clean up deprecated placeholder and menu API, bump version to 5.1.0dev1, remove obsolete models and fields, update tests, docs, and rebuild static assets.

Enhancements:

  • Remove deprecated Marker modifier, PlaceholderField, static placeholder rendering, and legacy utility functions
  • Update visibility checks to use get_visible_page_contents and drop old get_visible_nodes
  • Drop obsolete create_title alias and CMSPlaceholderAdmin mixins

Build:

  • Bump package version to 5.1.0dev1
  • Add new migration to remove PlaceholderReference.placeholder_ref and delete StaticPlaceholder model
  • Regenerate static assets (CSS/JS) under cms/static/cms/css/5.1.0dev1 and dist

Documentation:

  • Add upgrade guide for 5.1.0 release

Tests:

  • Remove tests for removed placeholder fields and adapt tests to new page visibility implementation

Chores:

  • Trim out dozens of deprecated functions and import paths across core modules
  • Remove dead template tags and admin static_placeholder module
  • Eliminate compatibility shims for Django CMS 5.1 deprecations

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented May 12, 2025 •
edited
Loading

Reviewer's Guide

This PR prepares the new 5.1.0 development branch by bumping the package version, removing deprecated placeholder and static‐placeholder machinery, cleaning up legacy utilities, regenerating static assets (CSS/JS) at the 5.1.0dev1 path, and updating tests and docs to reflect these removals.

File-Level Changes

Change Details Files
Version and asset path bump
  • Bumped version to 5.1.0dev1
  • Rebuilt CSS under cms/static/cms/css/5.1.0dev1
  • Rebuilt JS bundles under cms/static/cms/js/dist/5.1.0dev1
  • Deleted old 5.0.0 asset directories
 cms/__init__.py
cms/static/cms/css/...
cms/static/cms/js/dist/...
Removed deprecated StaticPlaceholder support
  • Dropped StaticPlaceholder model and placeholder_ref field
  • Deleted static placeholder admin mixin and template tags
  • Removed create_title alias in api
 cms/models/static_placeholder.py
cms/admin/static_placeholder.py
cms/migrations/0042_remove_placeholderreference_placeholder_ref_and_more.py
cms/templatetags/cms_tags.py
cms/api.py
Cleaned up legacy placeholder utilities
  • Removed PlaceholderField class
  • Replaced PlaceholderField in test fixtures with PlaceholderRelationField
  • Deleted Marker modifier and related deprecations
 cms/models/fields.py
cms/menus/modifiers.py
cms/test_utils/project/*/models.py
Pruned deprecated permission & plugin code
  • Removed various get_*_ids shims in page_permissions
  • Deleted has_page_permission compatibility wrapper
  • Removed static placeholder rendering methods from plugin_rendering
  • Updated cms/utils/permissions functions
 cms/utils/page_permissions.py
cms/utils/permissions.py
cms/plugin_rendering.py
Updated tests for removed features
  • Removed tests for PlaceholderField deprecations
  • Adapted tree tests to use get_visible_page_contents
  • Dropped static placeholder count assertion in admin tests
 cms/tests/test_placeholder.py
cms/tests/test_permmod.py
cms/tests/test_admin.py
cms/tests/test_extensions.py
Added upgrade documentation
  • Created docs/upgrade/5.1.0.rst
  • Updated docs/upgrade/index.rst
 docs/upgrade/5.1.0.rst
docs/upgrade/index.rst
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

fsbraun added 2 commits May 14, 2025 12:11
@fsbraun
fix: Structure board update sometimes failed to add all interactive e…
06e531a 
…lements (#8227)

* fix: Scan plugin data after structure mode Xhr load

* Fix test

* fix js linting issues
@fsbraun
fix: Update assets
4e764b9
@fsbraun
fix: Adjust checks for GrouperAdmin to allow for `prepopulated_fiel…
a6bdc74 
…ds` (#8232)

* fix: Adjust checks for GrouperAdmin to allow for `prepopulated_fields`

* Update cms/tests/test_grouper_admin.py
@fsbraun fsbraun marked this pull request as ready for review May 19, 2025 11:12
vinitkumar
vinitkumar approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@vinitkumar vinitkumar merged commit e15e017 into main May 21, 2025
67 checks passed
@github-actions github-actions bot deleted the release/build branch May 21, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitkumar vinitkumar vinitkumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsbraun @vinitkumar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.