Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: Improved delete page confirmation message #8070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 1, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Nov 6, 2024

Description

When selecting "Delete page..." from either the toolbar menu or in the page tree, a confirmation message is shown detailing which objects will be deleted. This used to be the standard Django delete confirmation message, which lists each instance of objects to be deleted, including each single page, page content, page url, version, plugin, version state tracking, plugin and other objects. As a result, the delete confirmation is often not seen as important or relevant to the user.

To improve UX, this PR proposes a simplified delete confirmation for pages only.

  • In the summary, it lists the number of pages, page contents and plugins that will be deleted.
  • As details, it contains the hierarchical page tree including page and page content objects. All other models are not explicitly listed.

Screenshot

image

(djangocms-admin-style hides the summary, unfortunately, but it renders nicely in plain Django admin or with djangocms-simple-admin-style)

(With #8067, the (bold) page titles will appear in the form of "My page title (/path/to/page)")

Feedback welcome (@jrief, @marksweb, @vinitkumar).

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested review from jrief and vinitkumar November 27, 2024 06:51
@vinitkumar
Copy link
Member

@fsbraun Code looks good. I think we need to fix those rufflint issues and then we are good to merge. I like the new UI a lot as it is very clear.

@fsbraun
Copy link
Member Author

fsbraun commented Nov 28, 2024

@vinitkumar Once you approve, I'm good to go!

Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get this merged and released 🚢 🚀

@vinitkumar vinitkumar merged commit 47b6301 into django-cms:develop-4 Dec 1, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.