Improved exception messages of builders #3092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misha-133
reviewed
Apr 10, 2025
src/Discord.Net.Core/Entities/Interactions/MessageComponents/Builders/ButtonBuilder.cs
Outdated
Show resolved
Hide resolved
Misha-133
approved these changes
Apr 14, 2025
Suiram1701
added a commit
to Suiram1701/Discord.Net
that referenced
this pull request
Apr 27, 2025
* Fixed type reader/converter parsing exception * Added the provided value to exceptions of some builders and, used more the Preconditions class. * Removed unused `System.Xml.Linq` usings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes its kind a hard to track back where some of the ArgumentException's are cumming from, so this PR adds the error causing value to the message manuel or by using Preconditions to improve the possablility to find the error causing value.
Changes
Related Issues
N/A