Fix MySQL migration compatibility with sql_require_primary_key #26374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ComfortablyCoding
requested changes
Dec 17, 2025
Member
ComfortablyCoding
left a comment
There was a problem hiding this comment.
This should be added as a schema helper so it can be reused in other migrations/locations.
Sample: #25280
…or dynamic primary key management
Contributor
Author
…chemaHelper and MySQL dialect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
ALTER TABLEstatement for MySQL when changing primary keys in migration20240204A-marketplace.tsTested Scenarios
sql_require_primary_key=ON(blackboxmysql-strict)upanddownfunctions work correctlyReview Notes / Questions
Checklist
Fixes #26324