fix: inconsistency in saving empty GitOps repository #6612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the working tree.
iamayushm
reviewed
May 28, 2025
iamayushm
reviewed
May 28, 2025
iamayushm
reviewed
May 28, 2025
iamayushm
reviewed
May 28, 2025
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 2763127 | Triggered | Generic High Entropy Secret | 84ce810 | scripts/devtron-reference-helm-charts/cronjob-chart_1-6-0/secrets-test-values.yaml | View secret |
| 141558 | Triggered | Generic High Entropy Secret | 84ce810 | scripts/devtron-reference-helm-charts/cronjob-chart_1-6-0/env-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
iamayushm
approved these changes
Jun 16, 2025
nishant-d
approved these changes
Jun 16, 2025
|
vikramdevtron
added a commit
that referenced
this pull request
Jun 19, 2025
* create cm in case of cluster event instead of secret * bump cpmmon lib * bump common lib * bump common lib * fix * k8s supported label label * small fix * bump common lib * bump common lib * bump * code review level 2 * added missing dependency (#6634) * fix * updates hash * fixed waiting to start status in deployemnt (#6649) * fix: Dependency upgrades (#6622) * removed hardcoded dependencies * k8s upgrade * helm and argo upgrade * helm and argo upgrade * golang.org/x/net upgrade * golang.org/x/net upgrade * DeleteProject gitlab client changes * common-lib sync * common lib sync * common-lib sync * Merge pull request #6651 from devtron-labs/fix-panic-cd-trigger fix: panic handling on cd trigger * main merge * make * fix: Posthog events added (#6640) * refact * app count events * app count events * app count events * app count events * query fix * policies included * wip * query fix posthog query * removed extra dockerFile count queries * fix * fix * fix: inconsistency in saving empty GitOps repository (#6612) * fix: gitops provider multiple save error * updated const ArgoRepoSyncDelayErr as per new ArgoCd update * fix: unable resolve 'HEAD' to a commit SHA * fix: git clone issue for empty repository * fix: ambiguous argument 'origin/HEAD': unknown revision or path not in the working tree. * fix: SSH known host confirmation issue on cloning * chore: updated default value of ARGO_REPO_REGISTER_RETRY_COUNT * chore: incorporated review comments * chore: removed dead code * chore: minor refactorings * chore: added integration test cases * fix: added handling for argocd older versions * sync: Main sync develop (#6669) * panic fixes (#6657) * fix-cd-pipeline-check (#6658) * vendor update on develop --------- Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com> * vendor update on rc 38 (#6671) * added empty migration seq (#6672) * fix down script for gp workload (#6678) * sync: Main sync RC (#6679) * panic fixes (#6657) * fix-cd-pipeline-check (#6658) * release: PR for v1.7.0 (#6667) * Updated release-notes files * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * removed init-container from git-sensor (#6605) Co-authored-by: Badal Kumar Prusty <badalkumar@Badals-MacBook-Pro.local> * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * feat: added support for loadBalancerIP (#6617) * added support for loadBalancerIP * removed default value for loadBalancerIP --------- Co-authored-by: Badal Kumar Prusty <badalkumar@Badals-MacBook-Pro.local> * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * set fsGroup to allow non-root app to write to PVC (#6664) Co-authored-by: Badal Kumar Prusty <badalkumar@Badals-MacBook-Pro.local> * misc: Shifted the dbConfigs under global (#6621) * Shifted the dbConfigs under global * updated the configurations for external database support * handled casbin migration case for database name * added support for custom annotations for ci-runner cd-runner and devtron * switched the conditioning to handle devtron-bom.yaml * removed check of values.global from postgresql.yaml * Updated kubewatch to a4fc9044-419-33852 tag in values file * Updated kubelink to a4fc9044-564-33855 tag in values file * Updated devtron to c8e75fb-434-33854 tag in values file * added support for nfs (#6665) Co-authored-by: Badal Kumar Prusty <badalkumar@Badals-MacBook-Pro.local> * Updated lens to a4fc9044-333-33874 tag in values file * Updated git-sensor to a4fc9044-200-33872 tag in values file * Updated dashboard to a85f2624-690-33873 tag in values file * Updated ci-runner to a4fc9044-138-33875 tag in values file * Updated notifier to 19d654ff-372-33876 tag in values file * Updated image-scanner to a4fc9044-141-33877 tag in values file * Updated chart-sync to a4fc9044-836-33878 tag in values file * Updated hyperion to c8e75fb-280-33879 tag in values file * Updated the nfs condition * Updated the version in scripts * updated release-notes file * Updated releasenotes.md * Updated release-notes-v1.7.0.md * finalized releasenotes --------- Co-authored-by: Badal Kumar <130441461+badal773@users.noreply.github.com> Co-authored-by: Badal Kumar Prusty <badalkumar@Badals-MacBook-Pro.local> Co-authored-by: akshatsinha007 <156403098+akshatsinha007@users.noreply.github.com> Co-authored-by: akshatsinha007 <akshat.sinha@devtron.ai> * vendor update on rc --------- Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com> Co-authored-by: systemsdt <129372406+systemsdt@users.noreply.github.com> Co-authored-by: Badal Kumar <130441461+badal773@users.noreply.github.com> Co-authored-by: Badal Kumar Prusty <badalkumar@Badals-MacBook-Pro.local> Co-authored-by: akshatsinha007 <156403098+akshatsinha007@users.noreply.github.com> Co-authored-by: akshatsinha007 <akshat.sinha@devtron.ai> --------- Co-authored-by: Prakash Kumar <prakash.kumar@devtron.ai> Co-authored-by: prakhar katiyar <39842461+prkhrkat@users.noreply.github.com> Co-authored-by: kartik-579 <kartik@devtron.ai> Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com> Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com> Co-authored-by: Asutosh Das <asutosh2000ad@gmail.com> Co-authored-by: systemsdt <129372406+systemsdt@users.noreply.github.com> Co-authored-by: Badal Kumar <130441461+badal773@users.noreply.github.com> Co-authored-by: Badal Kumar Prusty <badalkumar@Badals-MacBook-Pro.local> Co-authored-by: akshatsinha007 <156403098+akshatsinha007@users.noreply.github.com> Co-authored-by: akshatsinha007 <akshat.sinha@devtron.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2075
Checklist:
Does this PR introduce a user-facing change?