Dependabot pr combined #2983
Merged
Dependabot pr combined #2983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for devspace-docs canceled.
|
5ba2d77 to
82d663f
Compare
82d663f to
b881baa
Compare
Signed-off-by: Ryan Swanson <ryan.swanson@loft.sh>
Signed-off-by: Ryan Swanson <ryan.swanson@loft.sh>
Signed-off-by: Ryan Swanson <ryan.swanson@loft.sh>
Signed-off-by: Ryan Swanson <ryan.swanson@loft.sh>
Signed-off-by: Ryan Swanson <ryan.swanson@loft.sh>
Signed-off-by: Ryan Swanson <ryan.swanson@loft.sh>
Signed-off-by: Ryan Swanson <ryan.swanson@loft.sh>
Signed-off-by: Ryan Swanson <ryan.swanson@loft.sh>
b881baa to
0107e02
Compare
lizardruss
approved these changes
Aug 6, 2025
Collaborator
lizardruss
left a comment
There was a problem hiding this comment.
lgtm, as long as the UI was tested. We don't have an automated test for it, and we've had cases where a release went out with a broken UI. LMK if you need some pointers on testing it.
| dockerclient.CommonAPIClient | ||
| } | ||
|
|
||
| // TODO: (Ryan) see if these are needed for the tests |
Collaborator
Author
There was a problem hiding this comment.
Ah, nope. The dockerclient.APIClient interface changed, adding these methods. I retested by just making them all panic to see if any of it broke any tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #DSP-117
Please provide a short message that should be published in the DevSpace release notes
I went through the dependabot PRs and incorporated all those that worked without major changes and closed those that had bigger issues like API changes or breaking a bunch of peer dependencies after major version package updates.
What else do we need to know?