Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

use input instead of attribute #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 43 commits into from
Jan 12, 2022
Merged

use input instead of attribute #35

merged 43 commits into from
Jan 12, 2022

Conversation

micheelengronne
Copy link
Member

In the last versions of Inspec and cinc-auditor, attribute is deprecated and input should be used.

https://docs.chef.io/workstation/cookstyle/inspec_deprecations_attributehelper/

@micheelengronne micheelengronne force-pushed the micheelengronne-patch-1 branch from 88de9cc to e75ab12 Compare January 12, 2022 11:03
@micheelengronne micheelengronne self-assigned this Jan 12, 2022
@micheelengronne
Copy link
Member Author

@schurzi @chris-rock or @rndmh3ro what do you think ?

schurzi
schurzi approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@schurzi schurzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micheelengronne micheelengronne force-pushed the micheelengronne-patch-1 branch 5 times, most recently from 02723ab to 12c5ea7 Compare January 12, 2022 13:13
@micheelengronne
use input instead of attribute
b36d983 
In the last versions of Inspec and cinc-auditor, attribute is deprecated and input should be used.

https://docs.chef.io/workstation/cookstyle/inspec_deprecations_attributehelper/
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 1_2_master_node_api_server.rb
71d8f29 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 1_3_master_node_controller_manager.rb
c88028f 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 1_4_master_node_scheduler.rb
0b7d15b 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 2_etcd_node.rb
464ffbc 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 3_2_control_plane_logging.rb
04d6492 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 4_1_worker_node_configuration_files.rb
85fbc7a 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 4_2_worker_node_kubelet.rb
774721a 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 5_2_policies_pod_security_policies.rb
eef7113 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 5_3_policies_network_policies_and_cni.rb
0ce3377 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 5_4_policies_secrets_management.rb
1c91b39 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 5_5_policies_extensible_admission_control.rb
1689138 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 5_6_policies_general_policies.rb
0c670f3 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update inspec.yml
8b79268 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Create test.yml
5e536b2 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update Rakefile
a968559 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update Rakefile
5959b27 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update Gemfile
9beb7bc 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update .rubocop.yml
6e7ef48 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 1_1_master_node_configuration_files.rb
32950d8 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 1_2_master_node_api_server.rb
86795d5 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 1_3_master_node_controller_manager.rb
36ef970 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 1_4_master_node_scheduler.rb
40627d8 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 2_etcd_node.rb
a991c66 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 3_1_control_plane_authn_and_authz.rb
28b7e27 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 3_2_control_plane_logging.rb
dfd29cc 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 4_1_worker_node_configuration_files.rb
2e9cb5c 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 4_2_worker_node_kubelet.rb
66e58c8 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 5_1_policies_rbac_and_service_accounts.rb
e0a159d 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 5_2_policies_pod_security_policies.rb
1e9453d 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 5_3_policies_network_policies_and_cni.rb
995cd4d 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 5_4_policies_secrets_management.rb
2eaf484 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 5_5_policies_extensible_admission_control.rb
173f754 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update 5_6_policies_general_policies.rb
01dbcb0 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update kubernetes.rb
5430456 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update process_env_var.rb
bc9fafd 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update kubernetes.rb
6d3e666 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update process_env_var.rb
2991766 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update process_env_var.rb
3878445 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update process_env_var.rb
3f34c5f 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update process_env_var.rb
b8c3bea 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update process_env_var.rb
bec3a96 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne
Update process_env_var.rb
500c84d 
Signed-off-by: Michée Lengronne <michee.lengronne@coppint.com>
@micheelengronne micheelengronne force-pushed the micheelengronne-patch-1 branch from c1379f6 to 500c84d Compare January 12, 2022 13:54
@chris-rock chris-rock merged commit 81b5cb8 into master Jan 12, 2022
@chris-rock chris-rock deleted the micheelengronne-patch-1 branch January 12, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chris-rock chris-rock chris-rock approved these changes

@rndmh3ro rndmh3ro Awaiting requested review from rndmh3ro

@schurzi schurzi Awaiting requested review from schurzi

Assignees

@micheelengronne micheelengronne

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@micheelengronne @chris-rock @schurzi
Morty Proxy This is a proxified and sanitized view of the page, visit original site.