run the parsing of pieces for post-comma parts prior to checking if a… #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll post-comma elements are suffixes. this ensures that suffixes are properly captured in the constants prior to the all-suffix check
Contributor
Author
|
Hi @derek73 - any interest in this PR? any followup from me you'd like? |
Owner
|
Yes but I am traveling and won’t be able to take a closer look until next week sometime.
… On Nov 19, 2019, at 4:15 PM, Andrew Nichol ***@***.***> wrote:
Hi @derek73 - any interest in this PR? any followup from me you'd like?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Owner
|
Thanks for the pull request. Looks like you had to go pretty far down the rabbit hole to unravel that one. :) I appreciate it. Sorry it took so long to get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ll post-comma elements are suffixes. this ensures that suffixes are properly captured in the constants prior to the all-suffix check.
This is to fix an inconsistency issue where a name would get misparsed the first time it was parsed and correctly parsed any subsequent times.
Upstream:
With Fix:
Tests were identical to upstream, 11 expected failures.