Added capitalization rules to Constants class #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes a few minor spelling and spacing errors and ignores Pipenv files
These changes let users apply capitalization rules to all `HumanName` instances.
Owner
|
Thanks for this really useful addition to the parser. I definitely think there are others who have wanted this so I know it will be appreciated. Sorry it took me so long to get it merged. It's included in v1.0.5 published today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes let you set capitalization rules that are applied during instantiation.
Here are a few quick notes:
handle_capitalizationmethod to keep inline with how you've setup post processing within the parser.capitalizemethod, when used withforce=True, takes precedence over theforce_mixed_case_capitalizationsetting. This ensures you get what you expect.