Implemented support for escaping log entry arguments. #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
No problem. Thanks for the pull request! This will go out with v1.0.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I develop HIPAA compliant application and I need to escape all PHI (Protected Health Information) like first name and last name. I override handlers and escape all parameters for the template string by default. Unfortunately, I see the first name and last name in the logs in debug mode because the first argument (format string) not escaping.
Could you please approve that PR which replace
log.debug('full name: {}'.format('John Smith'))tolog.debug('full name: %s', 'John Smith'). It helps to escapeJohn Smithin the logs likefull name: **** *****.