Skip releases marked with DIRTY_RELEASE #4114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Farkas <daniel.farkas@csretail.cz>
* Add missing horizon tasks * Update laravel.php * Update laravel.php * format * Generate docs * Fix formatting * Add docs
* Bugfix dotenv test in laravel.php The test to check if .env file is present was not checking if the dotenv variable was set and always used the default. Added getter for dotenv variable. * change current_path to release_or_current_path in dotenv description Change instructions for set dotenv to use release_or_current_path variable. * change current_path to release_or_current_path in dotenv description Change instructions for set dotenv to use release_or_current_path variable. * Revert "Merge branch 'master' into patch-1" This reverts commit df230db, reversing changes made to 8a92805.
* Update typo3.php * Add regenerated docs * refactor: remove tasks to remove * refactor: wrap composer in set config option * refactor: enable user to choose transfer method * chore: regenerated documentation * fix: apply php-cs-fixer * refactor: use absolute path to execute typo3 binary * refactor: remove effectless warm up * refactor: rename public dir and adjust shared / writable dirs * refactor: rename rsync task for more consistency * refactor: adjust exclude list * refactor: make shared files configurable * refactor: extend cache flush * refactor: reduce shared files * fix: revert rsync task renaming
Since a Teams notification is not necessarily an essential part of a deploy, we should allow users to continue the deploy should a notification fail to send.
When using the local driver, all file operations are relative to the root directory defined in your filesystems configuration file. By default, this value is set to the storage/app/private directory. https://laravel.com/docs/12.x/filesystem#the-local-driver
|
Dirty releases are the only from deploy:push. deployer/recipe/deploy/push.php Line 24 in edc08f2 |
|
What we need is a way to track "finished" releases. |
Yes I saw that, and the flag seemed to be unused otherwise, but I liked the concept.
Right, that's much better. Interested in a PR? In which step should we set it? |
|
Yes, after the release it will get dropped in success. |
|
I'll make a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
37 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A canceled deployment (network disconnection, command aborted with ctrl+c) can leave an incomplete state in
.../releases/<number>.The next
dep rollbackwill roll back to that dirty release.I found the
releasestask mentioning (and showing) releases as "dirty" by looking for the DIRTY_RELEASE file. So I though it might be a good start to support that also during rollback.We could create and remove the file in appropriate steps during the usual deployment tasks in a separate PR. But users could also implement that themselves if needed.