Support format xml file which haven't yet persisted at the disk#4585
Merged
w0rp merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom Aug 20, 2023
Merged
Support format xml file which haven't yet persisted at the disk#4585w0rp merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom
w0rp merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom
Conversation
w0rp
reviewed
Aug 15, 2023
Member
w0rp
left a comment
There was a problem hiding this comment.
Does xmllint use the path to the file as part of its linting at all? If so, one thing we could try here is using the temporary filename if the buffer hasn't been saved yet, and the path to the file if it has been saved. We can have tests for each case.
Contributor
Author
|
@w0rp, fine, have updated the pr according your suggestion |
mnikulin
pushed a commit
to mnikulin/ale
that referenced
this pull request
Nov 12, 2023
…e-analysis#4585) Support format xml file which haven't yet persisted at the disk
cyyever
pushed a commit
to cyyever/ale
that referenced
this pull request
Mar 24, 2025
…e-analysis#4585) Support format xml file which haven't yet persisted at the disk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, xmllint is invalid if the buffer is not saved for now. and the pr can fix it