fix(vue): volar v1 support#4552
Merged
hsanson merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom Jul 24, 2023
creativenull:fix-volar-v1Copy head branch name to clipboard
Merged
fix(vue): volar v1 support#4552hsanson merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom creativenull:fix-volar-v1Copy head branch name to clipboard
hsanson merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom
creativenull:fix-volar-v1Copy head branch name to clipboard
Conversation
hsanson
approved these changes
Jul 24, 2023
Contributor
hsanson
left a comment
There was a problem hiding this comment.
Don't use volar myself but changes look good and this is affecting many users. Merging so it can be further tested.
|
Thanks for the quick turnaround on this! Specifically at the bottom, getting an exec check failure for the vue-language-server. I already have installed typescript in the package I am running; are there other dependencies? |
Contributor
Author
|
You need to have the vue-language-server installed globally with |
|
Ah it had to be global. Thanks a ton! |
mnikulin
pushed a commit
to mnikulin/ale
that referenced
this pull request
Nov 12, 2023
* fix: volar v1 support * fix: volar linter errors
cyyever
pushed a commit
to cyyever/ale
that referenced
this pull request
Mar 24, 2025
* fix: volar v1 support * fix: volar linter errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the discussion over on #4460 (reply in thread)
I've identified that volar v1 does have breaking changes.
Following the volar discussion (vuejs/language-tools#2279) I've adjusted the initialization options and added a warning message instructing the user to install
typescriptin the project in order for volar to work.