Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Adds erb-formatter support#4546

Merged
hsanson merged 1 commit intodense-analysis:masterdense-analysis/ale:masterfrom
arashm:erb-formatter-fixerarashm/ale:erb-formatter-fixerCopy head branch name to clipboard
Jul 24, 2023
Merged

Adds erb-formatter support#4546
hsanson merged 1 commit intodense-analysis:masterdense-analysis/ale:masterfrom
arashm:erb-formatter-fixerarashm/ale:erb-formatter-fixerCopy head branch name to clipboard

Conversation

@arashm
Copy link
Copy Markdown
Contributor

@arashm arashm commented Jul 3, 2023

Adds support for ERB::Formatter (https://github.com/nebulab/erb-formatter)

Tried to follow other MRs to create tests and relevant documentations.

@arashm arashm force-pushed the erb-formatter-fixer branch 4 times, most recently from 5ac630e to d345698 Compare July 3, 2023 15:56
@arashm
Copy link
Copy Markdown
Contributor Author

arashm commented Jul 3, 2023

I honestly can't figure out why the linter is failing. It's seems to me that I have put the erb-formatter in the correct position in the ToC, and also used ale-eruby-erb-formatter header. If someone could point me to the issues, it would be awesome. Thanks.

@arashm arashm force-pushed the erb-formatter-fixer branch from d345698 to 6058108 Compare July 3, 2023 23:22
@arashm arashm force-pushed the erb-formatter-fixer branch from 6058108 to 90452fd Compare July 3, 2023 23:51
@arashm
Copy link
Copy Markdown
Contributor Author

arashm commented Jul 3, 2023

Fixed all issues now.

Copy link
Copy Markdown
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@hsanson hsanson merged commit 93a4f70 into dense-analysis:master Jul 24, 2023
mnikulin pushed a commit to mnikulin/ale that referenced this pull request Nov 12, 2023
cyyever pushed a commit to cyyever/ale that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.