Fix error from ansible-lint versions >=6.11.0.#4492
Merged
hsanson merged 4 commits intodense-analysis:masterdense-analysis/ale:masterfrom Apr 7, 2023
SkrrtBacharach:ansible_lint_fixSkrrtBacharach/ale:ansible_lint_fixCopy head branch name to clipboard
Merged
Fix error from ansible-lint versions >=6.11.0.#4492hsanson merged 4 commits intodense-analysis:masterdense-analysis/ale:masterfrom SkrrtBacharach:ansible_lint_fixSkrrtBacharach/ale:ansible_lint_fixCopy head branch name to clipboard
hsanson merged 4 commits intodense-analysis:masterdense-analysis/ale:masterfrom
SkrrtBacharach:ansible_lint_fixSkrrtBacharach/ale:ansible_lint_fixCopy head branch name to clipboard
Conversation
Contributor
Author
|
I'm not really sure how to add tests for this, or if it's even possible. EDIT: read |
Contributor
|
There seems to be linter issues. Please fix those. |
The JSON output format of ansible-lint has changed since 6.11.0. Issue locations can have either a 'positions' or a 'lines' member, rather than just a 'lines' member as it was before. This fix checks which member is present, and passes that member name to subsequent dictionary lookups. The error was caused by the following change: ansible/ansible-lint#2897
f0b7cf3 to
cf7335c
Compare
Contributor
Author
Should be fixed now. |
mnikulin
pushed a commit
to mnikulin/ale
that referenced
this pull request
Nov 12, 2023
* Fix error from ansible-lint versions >=6.11.0. The JSON output format of ansible-lint has changed since 6.11.0. Issue locations can have either a 'positions' or a 'lines' member, rather than just a 'lines' member as it was before. This fix checks which member is present, and passes that member name to subsequent dictionary lookups. The error was caused by the following change: ansible/ansible-lint#2897 * Add ansible-lint test to check each type of ansible-lint issue json. * Change long single-line JSON in ansible test into multiline JSON. * Fix linting errors in ansible_lint.vim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON output format of ansible-lint has changed since 6.11.0. Issue locations can have either a 'positions' or a 'lines' member, rather than just a 'lines' member as it was before. This fix checks which member is present, and passes that member name to subsequent dictionary lookups.
The error was caused by the following change:
ansible/ansible-lint#2897