Improve struct and pointer autocompletion in C#4231
Merged
hsanson merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom Jul 4, 2022
s-marios:masterCopy head branch name to clipboard
Merged
Improve struct and pointer autocompletion in C#4231hsanson merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom s-marios:masterCopy head branch name to clipboard
hsanson merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom
s-marios:masterCopy head branch name to clipboard
Conversation
Contributor
|
I tested this with the sample code in the issue and auto-completion works fine with the chages to fix "1.". The changes done for "2." break auto-completion and from my testing are not required. Note that I use asynccomplete for auto-completion instead of ALE's built in auto-completion. |
Contributor
Author
|
@hsanson unfortunate to hear that patch 2 breaks autocompletion with asynccomplete. I do not know enough about how it interacts with ALE. Can you try with ale's built-in autocompletion function? One more question, I tried to look into the appveyor results, but for the life of me I couldn't find which tests broke. What should I be looking for? |
hsanson
reviewed
Jun 24, 2022
hsanson
reviewed
Jun 28, 2022
hsanson
reviewed
Jun 29, 2022
hsanson
previously approved these changes
Jul 3, 2022
Contributor
hsanson
left a comment
There was a problem hiding this comment.
Thanks for the work. Looks good and tested works on my setup.
Contributor
|
@s-marios seems that the new patterns need to be also added to this test: |
Contributor
Author
|
Ah, sorry about that. Amended the test, run locally all tests passed. History rewritten, rebased, it should be ready to go! |
cyyever
pushed a commit
to cyyever/ale
that referenced
this pull request
Jul 11, 2022
* Add explicit trigger characters for C (dense-analysis#4226) * Stop completion before issuing subsequent requests (dense-analysis#4226) Co-authored-by: Marios Sioutis <26476573+s-marios@users.noreply.github.com>
cyyever
pushed a commit
to cyyever/ale
that referenced
this pull request
Jul 11, 2022
* Add explicit trigger characters for C (dense-analysis#4226) * Stop completion before issuing subsequent requests (dense-analysis#4226) Co-authored-by: Marios Sioutis <26476573+s-marios@users.noreply.github.com>
hsanson
added a commit
to hsanson/ale
that referenced
this pull request
Jul 13, 2022
In dense-analysis#4231 some code was added to stop the completion menu if any when opening a new one. This resulted in an issue in Vim that fills the buffer with Ctrl-Z characters when deleting to the end of a line in a position that triggers auto-completion. Since auto-completion seems to work fine on all my tests I am reverting this specific change.
hsanson
added a commit
that referenced
this pull request
Jul 13, 2022
In #4231 some code was added to stop the completion menu if any when opening a new one. This resulted in an issue in Vim that fills the buffer with Ctrl-Z characters when deleting to the end of a line in a position that triggers auto-completion. Since auto-completion seems to work fine on all my tests I am reverting this specific change.
mnikulin
pushed a commit
to mnikulin/ale
that referenced
this pull request
Nov 12, 2023
In dense-analysis#4231 some code was added to stop the completion menu if any when opening a new one. This resulted in an issue in Vim that fills the buffer with Ctrl-Z characters when deleting to the end of a line in a position that triggers auto-completion. Since auto-completion seems to work fine on all my tests I am reverting this specific change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses #4226 and comes in two patches:
For the first patch, ALE currently does not use the trigger characters advertised by the LSP. Thus it is necessary to hard-code trigger characters. This patch introduces
->in order to make autocompletion with pointers possible.The second patch is a proof-of-concept on how ALE should behave when a newer autocompletion request has been sent to the server. Currently, if there was a previous autocomplete request, the autocomplete operation will not stop if the user enters the full name of a variable and then a trigger character, which results in no completion candidates even though ALE did talk to the LSP and retrieved completion candidates successfully (see #4226 for this description). This patch stops the previous completion operation, and ALE is able to show a new autocompletion menu with the updated, more recent completion candidates.
Review and further comments on getting this merged are greatly appreciated!