Set default value for insertTextFormat#4124
Merged
w0rp merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom Apr 1, 2022
JD557:default-insert-text-formatJD557/ale:default-insert-text-formatCopy head branch name to clipboard
Merged
Set default value for insertTextFormat#4124w0rp merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom JD557:default-insert-text-formatJD557/ale:default-insert-text-formatCopy head branch name to clipboard
w0rp merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom
JD557:default-insert-text-formatJD557/ale:default-insert-text-formatCopy head branch name to clipboard
Conversation
cyyever
pushed a commit
to cyyever/ale
that referenced
this pull request
Jul 11, 2022
Co-authored-by: w0rp <devw0rp@gmail.com>
cyyever
pushed a commit
to cyyever/ale
that referenced
this pull request
Jul 11, 2022
Co-authored-by: w0rp <devw0rp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the spec (https://microsoft.github.io/language-server-protocol/specification#textDocument_completion),
insertTextFormatshould default toInsertTextFormat.PlainTextwhen ommited.Unfortunately, I'm not very familiar with viml develpment and couldn't run the
./run-testsscript (I keep getting an error that the image is not known, even with--build-image), so I ended up not writing any tests nor checking if the current tests pass...