Find composer.json when searching for psalm#3979
Merged
hsanson merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom Nov 15, 2021
diskshima:psalm-add-support-for-composer-jsondiskshima/ale:psalm-add-support-for-composer-jsonCopy head branch name to clipboard
Merged
Find composer.json when searching for psalm#3979hsanson merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom diskshima:psalm-add-support-for-composer-jsondiskshima/ale:psalm-add-support-for-composer-jsonCopy head branch name to clipboard
hsanson merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom
diskshima:psalm-add-support-for-composer-jsondiskshima/ale:psalm-add-support-for-composer-jsonCopy head branch name to clipboard
Conversation
diskshima
commented
Nov 14, 2021
| Execute(The project path should be correct for composer.json file): | ||
| call ale#test#SetFilename('../test-files/php/with-composer/test.php') | ||
|
|
||
| AssertLSPProject ale#path#Simplify(g:dir . '/../test-files/php/with-composer') |
Contributor
Author
There was a problem hiding this comment.
I'm using AssertLSPProject here but not sure if this is the best way to test this case.
I'll be more than happy to be corrected ;)
hsanson
approved these changes
Nov 15, 2021
Contributor
hsanson
left a comment
There was a problem hiding this comment.
Looks good, thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a lookup for a directory with
composer.jsonin it when trying to find thepsalmexecutable undervendor/bin.Previously it looked for the
.git/directory but some projects may not necessarily have theirvendor/bindirectory placed at their project root.