fix: cflags parser: no absolute path for '-include'#3775
Merged
hsanson merged 1 commit intodense-analysis:masterdense-analysis/ale:masterfrom Jul 4, 2021
mjeanson:masterCopy head branch name to clipboard
Merged
fix: cflags parser: no absolute path for '-include'#3775hsanson merged 1 commit intodense-analysis:masterdense-analysis/ale:masterfrom mjeanson:masterCopy head branch name to clipboard
hsanson merged 1 commit intodense-analysis:masterdense-analysis/ale:masterfrom
mjeanson:masterCopy head branch name to clipboard
Conversation
Both '-include' and '-imacros' take a file as an argument that will then be searched in the include path like a regular '#include "..."' statement in a source file. As such, they should not have their path converted to an absolute path. Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both '-include' and '-imacros' take a file as an argument that will then
be searched in the include path like a regular '#include "..."'
statement in a source file. As such, they should not have their path
converted to an absolute path.