Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Deno support for LSP and fixer#3533

Merged
hsanson merged 4 commits intodense-analysis:masterdense-analysis/ale:masterfrom
motato1:mastermotato1/ale:masterCopy head branch name to clipboard
Jan 23, 2021
Merged

Deno support for LSP and fixer#3533
hsanson merged 4 commits intodense-analysis:masterdense-analysis/ale:masterfrom
motato1:mastermotato1/ale:masterCopy head branch name to clipboard

Conversation

@motato1
Copy link
Copy Markdown
Contributor

@motato1 motato1 commented Jan 11, 2021 •
edited
Loading

Deno is a JavaScript and TypeScript runtime akin to Node, however it does not use Node packages/npm.
As of version 1.6.0, Deno brings its own Language Server implementation, though it is not yet feature-complete (see denoland/deno#8643).

This PR integrates Deno LSP support as well as the built-in fixer (deno fmt) into ALE (TypeScript only).

Currently, no version check is performed to see if LSP is supported (although I mention the required version in the help file).
If that is a requirement, please let me know. Also, a pointer to an example of how version checks are usually performed in ALE would be helpful.

@motato1 motato1 marked this pull request as ready for review January 11, 2021 22:05
@hsanson
Copy link
Copy Markdown
Contributor

hsanson commented Jan 22, 2021

ALE migrated from Travis to Github Actions (see #3548) so it is necessary to rebase this PR from latest master branch to trigger the required checks.

# Add dense-analysis as remote upstream on your local fork. Not 
# needed if already added.
git remote add upstream https://github.com/dense-analysis/ale.git

# Sync your local master with upstream master
git checkout master
git fetch upstream master
git merge upstream/master

# Rebase the PR branch with master
git checkout my-branch-name
git rebase master   # Fix any conflicts you may have

# Force push the updated PR branch to origin to trigger the checks
git push -f origin my-branch-name

@motato1
Copy link
Copy Markdown
Contributor Author

motato1 commented Jan 22, 2021

Thank you.
I rebased my branch onto upstream master and fixed the documentation to satisfy the linters.

hsanson
hsanson approved these changes Jan 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@hsanson hsanson merged commit c374736 into dense-analysis:master Jan 23, 2021
@motato1 motato1 mentioned this pull request Jan 25, 2021
Merged
@jayli jayli mentioned this pull request Feb 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hsanson hsanson hsanson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@motato1 @hsanson
Morty Proxy This is a proxified and sanitized view of the page, visit original site.