dafny: add a timeLimit option and message-parsing#3475
Merged
hsanson merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom Jan 20, 2021
benknoble:dafny-include-timeoutsbenknoble/ale:dafny-include-timeoutsCopy head branch name to clipboard
Merged
dafny: add a timeLimit option and message-parsing#3475hsanson merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom benknoble:dafny-include-timeoutsbenknoble/ale:dafny-include-timeoutsCopy head branch name to clipboard
hsanson merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom
benknoble:dafny-include-timeoutsbenknoble/ale:dafny-include-timeoutsCopy head branch name to clipboard
Conversation
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
Contributor
Author
|
@w0rp should be passing |
hsanson
approved these changes
Jan 20, 2021
Contributor
hsanson
left a comment
There was a problem hiding this comment.
Looks good. Tests in order too and no visible backward compatibility issues.
Contributor
Author
Contributor
|
@benknoble I do not use Dafny but from what I have read it seems using filenames would be useful in this case. It will allow ALE to show errors on files still not open (no buffer) in vim/nvim. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The option itself was manually tested.
The message-parsing has a new test.
#3390 should probably merge first, which will necessitate some updates to this PR.