Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(ale_linters/phpcs): add support for multiline error messages#3282

Merged
w0rp merged 1 commit intodense-analysis:masterdense-analysis/ale:masterfrom
zanona:masterzanona/ale:masterCopy head branch name to clipboard
Nov 21, 2020
Merged

fix(ale_linters/phpcs): add support for multiline error messages#3282
w0rp merged 1 commit intodense-analysis:masterdense-analysis/ale:masterfrom
zanona:masterzanona/ale:masterCopy head branch name to clipboard

Conversation

@zanona
Copy link
Copy Markdown
Contributor

@zanona zanona commented Aug 12, 2020 •
edited
Loading

This PR adds support for phpcs when there are errors resulting on messages containing more than one line.

An example would be :

<?php
$foo = 'bar';
echo "
<div>
    <h1>hello world</h1>
    <p>$foo</p>
</div>
";

Before this fix, the command below would return an error, but Ale wouldn't catch it.

$ phpcs --report=emacs theme/single-member.php
/home/user/file-name.php:14:10: error - All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '"
'.

@zanona zanona force-pushed the master branch 3 times, most recently from b0f8a04 to c86519a Compare August 12, 2020 09:49
@zanona zanona marked this pull request as ready for review August 12, 2020 09:54
@zanona
Copy link
Copy Markdown
Contributor Author

zanona commented Aug 12, 2020

Unrelated test error at /testplugin/test/command_callback/test_bingo_command_callback.vader

@stale
Copy link
Copy Markdown

stale Bot commented Sep 25, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale Bot added the stale PRs/Issues no longer valid label Sep 25, 2020
@stale stale Bot removed the stale PRs/Issues no longer valid label Sep 25, 2020
@zanona
Copy link
Copy Markdown
Contributor Author

zanona commented Sep 25, 2020

Rebasing seems to have fixed tests, as it was unrelated. cc / @w0rp

@stale
Copy link
Copy Markdown

stale Bot commented Oct 23, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale Bot added the stale PRs/Issues no longer valid label Oct 23, 2020
@stale stale Bot closed this Oct 30, 2020
@zanona
Copy link
Copy Markdown
Contributor Author

zanona commented Oct 30, 2020 •
edited
Loading

@w0rp could you please point someone to review this PR? I'm not quite sure what else I could've done here. Tests passed and all...

@w0rp w0rp reopened this Nov 21, 2020
@stale stale Bot removed the stale PRs/Issues no longer valid label Nov 21, 2020
w0rp
w0rp approved these changes Nov 21, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good, I've just been too busy to look at ALE pull requests in recent months.

@w0rp w0rp merged commit df31632 into dense-analysis:master Nov 21, 2020
@w0rp
Copy link
Copy Markdown
Member

w0rp commented Nov 21, 2020

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@w0rp w0rp w0rp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanona @w0rp
Morty Proxy This is a proxified and sanitized view of the page, visit original site.