Improve :ALEDetail for dockerfile_lint [READY TO REVIEW]#3158
Merged
hsanson merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom Jun 20, 2020
ulidtko:improve-dockerfile_lintulidtko/ale:improve-dockerfile_lintCopy head branch name to clipboard
Merged
Improve :ALEDetail for dockerfile_lint [READY TO REVIEW]#3158hsanson merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom ulidtko:improve-dockerfile_lintulidtko/ale:improve-dockerfile_lintCopy head branch name to clipboard
hsanson merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom
ulidtko:improve-dockerfile_lintulidtko/ale:improve-dockerfile_lintCopy head branch name to clipboard
Conversation
1. The often longish `description` moved away from (supposedly short) statusline `message` into the `detail` section. 2. dockerfile_lint sends `reference_url` pointing to issue explanations. Use that.
Contributor
Author
|
CI is green! ✔️ Please review, this is ready to merge. |
ulidtko
added a commit
to ulidtko/versioned-configs
that referenced
this pull request
May 7, 2020
That is, until dense-analysis/ale#3158 gets merged.
hsanson
approved these changes
Jun 20, 2020
Contributor
hsanson
left a comment
There was a problem hiding this comment.
Just tested this and works fine.
ulidtko
added a commit
to ulidtko/versioned-configs
that referenced
this pull request
Jun 25, 2020
dense-analysis/ale#3158 has been merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This just makes the existing integration with dockerfile_lint a bit nicer.
Tested manually and via
./run-tests. Existing unit-test updated to includedetail.BTW: thoroughly enjoyed making the patch; thanks for nice docs & test infra. Cheers!