Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use maven wrapper if available#2934

Closed
fenuks wants to merge 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom
fenuks:maven_helperCopy head branch name to clipboard
Closed

Use maven wrapper if available#2934
fenuks wants to merge 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom
fenuks:maven_helperCopy head branch name to clipboard

Conversation

@fenuks
Copy link
Copy Markdown
Contributor

@fenuks fenuks commented Dec 16, 2019

This merge request adds maven.vim helper that extracts code for working with maven projects, adds detection for mvnw (and mvnw.cmd on Windows) wrapper. If wrapper is available, it is used to determine root of the maven project, and if it is executable, it is also used instead of global mvn command to generate classpath list.

Tests are included, based on analogous tests for gradle.vim helper.

@fenuks
Copy link
Copy Markdown
Contributor Author

fenuks commented Jan 28, 2020

Hello, since there are no change requests, can this get merged? :)

@stale
Copy link
Copy Markdown

stale Bot commented Aug 13, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale Bot added the stale PRs/Issues no longer valid label Aug 13, 2020
@stale stale Bot closed this Aug 15, 2020
@fenuks
Copy link
Copy Markdown
Contributor Author

fenuks commented Sep 29, 2020

@w0rp Could you take look at this? I think it's good to go, changes had been reviewed, there are tests, and no conflicts (I've rebased it to sit on top of the latest upstream version, but since this pull request is closed, update is not shown).

@hsanson
Copy link
Copy Markdown
Contributor

hsanson commented Oct 1, 2020

@fenuks can you reopen this PR? I cannot for some reason. I will merge this if you manage to reopen it. I had tested this and works fine.

@fenuks
Copy link
Copy Markdown
Contributor Author

fenuks commented Oct 1, 2020

Sadly, I cannot. I guess the fastest way will be opening a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PRs/Issues no longer valid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.